FIX-#4409: Fix eval_insert utility that doesn't actually check results of insert function
#4410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocked by #4408 |
Codecov Report
@@ Coverage Diff @@
## master #4410 +/- ##
==========================================
+ Coverage 86.82% 89.54% +2.71%
==========================================
Files 222 222
Lines 18038 18038
==========================================
+ Hits 15662 16152 +490
+ Misses 2376 1886 -490
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
|
|
|
I believe this should be unblocked now, right? |
Signed-off-by: Anatoly Myachev <anatoliimyachev@mail.com>
Signed-off-by: Anatoly Myachev <anatoliimyachev@mail.com>
Co-authored-by: Rehan Sohail Durrani <rdurrani@berkeley.edu>
Signed-off-by: Anatoly Myachev <anatoliimyachev@mail.com>
Signed-off-by: Anatoly Myachev <anatoliimyachev@mail.com>
Signed-off-by: Anatoly Myachev <anatoliimyachev@mail.com>
anmyachev
changed the title
eval_insert utility and fixes for insert functioneval_insert utility that doesn't actually check results of insert function
anmyachev
commented
May 4, 2022
Comment on lines
+1164
to
+1168
| raise ValueError( | ||
| "Length of values ({}) does not match length of index ({})".format( | ||
| len(value), len(self.index) | ||
| ) | ||
| ) |
There was a problem hiding this comment.
In the process of manual testing, I accidentally found a message mismatch in an exception regarding pandas.
anmyachev
commented
May 5, 2022
| @@ -71,6 +71,7 @@ def eval_insert(modin_df, pandas_df, **kwargs): | |||
| modin_df, | |||
| pandas_df, | |||
| operation=lambda df, **kwargs: df.insert(**kwargs), | |||
| __inplace__=True, | |||
There was a problem hiding this comment.
Insert function doesn't return anything, so we should explicitly use __inplace__=True here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -seval_insertutil function doesn't actually check results ofinsertoperation #4409docs/development/architecture.rstis up-to-date