-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX-#4409: Fix eval_insert
utility that doesn't actually check results of insert
function
#4410
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
7f31b2c
FIX-#4407: fix 'insert' function in case of numpy array
anmyachev eb2fb78
fix another case
anmyachev efb6747
Update modin/pandas/dataframe.py
anmyachev 9f7f1c3
refactoring
anmyachev 41cb980
FIX-#4409: fix 'eval_insert' utility
anmyachev f1f12bf
add release note
anmyachev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -71,6 +71,7 @@ def eval_insert(modin_df, pandas_df, **kwargs): | |
modin_df, | ||
pandas_df, | ||
operation=lambda df, **kwargs: df.insert(**kwargs), | ||
__inplace__=True, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Insert function doesn't return anything, so we should explicitly use |
||
**_kwargs, | ||
) | ||
|
||
|
@@ -1049,7 +1050,6 @@ def comparator(df1, df2): | |
loc=0, | ||
col=f"test_col{idx}", | ||
value=value, | ||
__inplace__=True, | ||
comparator=lambda df1, df2: comparator(df1, df2), | ||
) | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the process of manual testing, I accidentally found a message mismatch in an exception regarding pandas.