Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#6336: pin 'pydantic<2' to fix CI #6337

Merged
merged 1 commit into from
Jul 1, 2023
Merged

FIX-#6336: pin 'pydantic<2' to fix CI #6337

merged 1 commit into from
Jul 1, 2023

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Jun 30, 2023 •
edited
Loading

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Ray is incompatible with pydantic>=2.0 #6336
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev
FIX-modin-project#6336: pin 'pydantic<2' to fix CI
371cad8 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev marked this pull request as ready for review June 30, 2023 23:51
@anmyachev anmyachev requested a review from a team as a code owner June 30, 2023 23:51
@anmyachev anmyachev added the P0 Highest priority tasks requiring immediate fix label Jul 1, 2023
vnlitvinov
vnlitvinov approved these changes Jul 1, 2023
View reviewed changes
Copy link
Collaborator

@vnlitvinov vnlitvinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Note that Ray is going to release this pin themselves in 2.6: ray-project/ray#37000

@vnlitvinov vnlitvinov merged commit f32a9bd into modin-project:master Jul 1, 2023
@vnlitvinov vnlitvinov added the Backport 🔙 Issues that need to be backported to previous release(s) label Jul 1, 2023
@anmyachev
Copy link
Collaborator Author

Thanks @vnlitvinov!

@anmyachev anmyachev deleted the issue6336 branch July 1, 2023 14:46
vnlitvinov pushed a commit that referenced this pull request Jul 1, 2023
@anmyachev @vnlitvinov
FIX-#6336: pin 'pydantic<2' to fix CI (#6337)
df79988 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@vnlitvinov vnlitvinov mentioned this pull request Jul 1, 2023
Merged
vnlitvinov pushed a commit that referenced this pull request Jul 3, 2023
@anmyachev @vnlitvinov
FIX-#6336: pin 'pydantic<2' to fix CI (#6337)
3502cd8 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vnlitvinov vnlitvinov vnlitvinov approved these changes

Assignees
No one assigned
Labels
Backport 🔙 Issues that need to be backported to previous release(s) P0 Highest priority tasks requiring immediate fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ray is incompatible with pydantic>=2.0
2 participants
@anmyachev @vnlitvinov