Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin pydantic to < 2.0.0 #37000

Merged
merged 4 commits into from
Jul 1, 2023
Merged

Conversation

alanwguo
Copy link
Contributor

Why are these changes needed?

2.0.0 brings breaking changes

Here's a failed CI run: https://buildkite.com/ray-project/oss-ci-build-pr/builds/27338#01890d26-94ff-42f2-80be-c2ac0a86e8d3/447-762

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

alanwguo added 2 commits June 30, 2023 11:26
2.0.0 brings breaking changes

Signed-off-by: Alan Guo <aguo@anyscale.com>
Signed-off-by: Alan Guo <aguo@anyscale.com>
@pcmoritz
Copy link
Contributor

pcmoritz commented Jun 30, 2023

Don't forget to fix the code to be compatible with version 2 after this is merged -- maybe we should put in a <3 pin at that point :)

alanwguo added 2 commits June 30, 2023 15:45
Signed-off-by: Alan Guo <aguo@anyscale.com>
Copy link
Contributor

@pcmoritz pcmoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this merged -- at least it puts out the fire and then we can make sure we can be compatible with both pydantic 1 and 2 going forward.

@alanwguo
Copy link
Contributor Author

alanwguo commented Jul 1, 2023

CI seems to be in a really bad state. i doubt any of the failures are related. Should we just merge?

@pcmoritz
Copy link
Contributor

pcmoritz commented Jul 1, 2023

Yeah, I believe the failures are unrelated.

We need one more codeowner approval, @ericl can you do that? :)

@alanwguo alanwguo added the release-blocker P0 Issue that blocks the release label Jul 1, 2023
@pcmoritz pcmoritz merged commit c07ed7e into ray-project:master Jul 1, 2023
alanwguo added a commit to alanwguo/ray that referenced this pull request Jul 1, 2023
@alanwguo alanwguo mentioned this pull request Jul 1, 2023
8 tasks
@pcmoritz pcmoritz mentioned this pull request Jul 1, 2023
@ddelange
Copy link
Contributor

hi 👋 will this be part of the ray 2.7 release? or more generally: will ray 2.7 release from master branch?

arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
2.0.0 brings breaking changes

Here's a failed CI run: https://buildkite.com/ray-project/oss-ci-build-pr/builds/27338#01890d26-94ff-42f2-80be-c2ac0a86e8d3/447-762

Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-blocker P0 Issue that blocks the release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants