-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin pydantic to < 2.0.0 #37000
Pin pydantic to < 2.0.0 #37000
Conversation
2.0.0 brings breaking changes Signed-off-by: Alan Guo <aguo@anyscale.com>
Don't forget to fix the code to be compatible with version 2 after this is merged -- maybe we should put in a |
Signed-off-by: Alan Guo <aguo@anyscale.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this merged -- at least it puts out the fire and then we can make sure we can be compatible with both pydantic 1 and 2 going forward.
CI seems to be in a really bad state. i doubt any of the failures are related. Should we just merge? |
Yeah, I believe the failures are unrelated. We need one more codeowner approval, @ericl can you do that? :) |
2.0.0 brings breaking changes Here's a failed CI run: https://buildkite.com/ray-project/oss-ci-build-pr/builds/27338#01890d26-94ff-42f2-80be-c2ac0a86e8d3/447-762
2.0.0 brings breaking changes Here's a failed CI run: https://buildkite.com/ray-project/oss-ci-build-pr/builds/27338#01890d26-94ff-42f2-80be-c2ac0a86e8d3/447-762
hi 👋 will this be part of the ray 2.7 release? or more generally: will ray 2.7 release from |
2.0.0 brings breaking changes Here's a failed CI run: https://buildkite.com/ray-project/oss-ci-build-pr/builds/27338#01890d26-94ff-42f2-80be-c2ac0a86e8d3/447-762 Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Why are these changes needed?
2.0.0 brings breaking changes
Here's a failed CI run: https://buildkite.com/ray-project/oss-ci-build-pr/builds/27338#01890d26-94ff-42f2-80be-c2ac0a86e8d3/447-762
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.