Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check for package exist when uploading it #15267

Merged
merged 4 commits into from
Feb 24, 2021
Merged

Added check for package exist when uploading it #15267

merged 4 commits into from
Feb 24, 2021

Conversation

Ruslan-Aleev
Copy link
Collaborator

What does it do?

  • Added check for package exist when uploading it
  • Moved lines to lexicons
  • Fixed styles for package installer - an icon is now visible to indicate that drag and drop is working
    installer_icon

How it looks now:
package_check

Related issue(s)/PR(s)

#8371
#13851

@cla-bot cla-bot bot added the cla-signed CLA confirmed for contributors to this PR. label Sep 23, 2020
core/lexicon/en/file.inc.php Outdated Show resolved Hide resolved
core/lexicon/en/file.inc.php Outdated Show resolved Hide resolved
Comment on lines +110 to +111
// Check if a file exists
if (file_exists($newPath)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary comment

core/lexicon/en/file.inc.php Outdated Show resolved Hide resolved
@Ibochkarev Ibochkarev added this to the v3.0.0-alpha3 milestone Feb 11, 2021
@Ibochkarev Ibochkarev added the pr/ready-for-merging Pull request reviewed and tested and ready for merging. label Feb 11, 2021
@opengeek opengeek merged commit 2dea5a6 into modxcms:3.x Feb 24, 2021
@opengeek opengeek removed the pr/ready-for-merging Pull request reviewed and tested and ready for merging. label Feb 24, 2021
@Ruslan-Aleev Ruslan-Aleev deleted the 3.x-pr-15232-2 branch February 24, 2021 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA confirmed for contributors to this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants