Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Form Customization: Grid editing erases set data #15954

Closed
wants to merge 1,710 commits into from
Closed

[3.x] Form Customization: Grid editing erases set data #15954

wants to merge 1,710 commits into from

Conversation

theboxer
Copy link
Member

@theboxer theboxer commented Jan 6, 2022 •
edited
Loading

No description provided.

theboxer and others added 30 commits February 23, 2021 13:51
@theboxer
[3.x] Fix plugin's event property sets (modxcms#15408)
4e8914e
@Ruslan-Aleev
Changed the default gravatar type (modxcms#15406)
7913c2f
@Ibochkarev
Fix fatal error: "Uncaught Error: Call to undefined function get_magi…
8d06e31 
…c_quotes_gpc()" on PHP8 (modxcms#15404)
@Ibochkarev @opengeek
[3.x] Improve the processor permission response error message (modxcm…
f2e0990 
…s#15403)

* Improve the processor response error message

* Fix the wrong error message

* grunt build

Co-authored-by: Jason Coward <jason@opengeek.com>
@Ruslan-Aleev @opengeek
Added check for package exist when uploading it (modxcms#15267)
2dea5a6 
* Added check for file exist

* Added lexicons

* Fixed styles for package installer

* grunt build

Co-authored-by: Jason Coward <jason@opengeek.com>
@Ruslan-Aleev
Reordered the navigation tabs in the "User Group" (modxcms#15149)
2517359 
* Changed lexicons to more specific

* Reordered the navigation tabs
@Ruslan-Aleev @opengeek
Fixed collapsing tree on mobile screens (modxcms#15229)
2a8ca3c 
* Fixed collapsing tree on mobile screens

* grunt build

Co-authored-by: Jason Coward <jason@opengeek.com>
@Jako @opengeek
JsonGrid fixes (modxcms#15346)
d615819 
* Fix JsonGrid

- Change the gridEditor record value of the currently edited field on keyup
- Don't use the context menu. This does not make sense with only one entry in that menu

* Fix a not displayed value change in the grid

* Remove the column menu for the grid and for the action columns.

* grunt build

Co-authored-by: Jason Coward <jason@opengeek.com>
@theboxer
Fix rendering italic value (modxcms#15389)
c280d9e
@theboxer
Fix breadcrumbs on new resources (modxcms#15391)
988b729
@Jako @opengeek
Fix country name in the user section is not always displayed (modxcms…
c768565 
…#15413)

* Fix country name in the user section is not always displayed

* grunt build

Co-authored-by: Jason Coward <jason@opengeek.com>
@modxbot
New Crowdin updates (modxcms#15409)
35ae3ee 
* New translations default.inc.php (Romanian)

* New translations default.inc.php (Dutch)

* New translations default.inc.php (Hindi)

* New translations default.inc.php (Estonian)

* New translations default.inc.php (Thai)

* New translations default.inc.php (Persian)

* New translations default.inc.php (Indonesian)

* New translations default.inc.php (Chinese Simplified)

* New translations default.inc.php (Ukrainian)

* New translations default.inc.php (Turkish)

* New translations default.inc.php (Swedish)

* New translations default.inc.php (Russian)

* New translations default.inc.php (Portuguese)

* New translations default.inc.php (Polish)

* New translations default.inc.php (Japanese)

* New translations default.inc.php (French)

* New translations default.inc.php (Italian)

* New translations default.inc.php (Hungarian)

* New translations default.inc.php (Hebrew)

* New translations default.inc.php (Finnish)

* New translations default.inc.php (Greek)

* New translations default.inc.php (German)

* New translations default.inc.php (Danish)

* New translations default.inc.php (Czech)

* New translations default.inc.php (Bulgarian)

* New translations default.inc.php (Belarusian)

* New translations default.inc.php (Arabic)

* New translations default.inc.php (Spanish)

* New translations default.inc.php (Yoruba)

* New translations about.inc.php (Belarusian)

* New translations file.inc.php (Arabic)

* New translations file.inc.php (Finnish)

* New translations file.inc.php (Greek)

* New translations file.inc.php (German)

* New translations access.inc.php (German)

* New translations file.inc.php (Danish)

* New translations file.inc.php (Czech)

* New translations file.inc.php (Bulgarian)

* New translations default.inc.php (Belarusian)

* New translations file.inc.php (Belarusian)

* New translations file.inc.php (Spanish)

* New translations file.inc.php (Hungarian)

* New translations file.inc.php (French)

* New translations file.inc.php (Romanian)

* New translations file.inc.php (Hebrew)

* New translations file.inc.php (Italian)

* New translations file.inc.php (Swedish)

* New translations file.inc.php (Hindi)

* New translations file.inc.php (Estonian)

* New translations file.inc.php (Thai)

* New translations file.inc.php (Persian)

* New translations file.inc.php (Indonesian)

* New translations file.inc.php (Chinese Simplified)

* New translations file.inc.php (Ukrainian)

* New translations access.inc.php (Ukrainian)

* New translations file.inc.php (Turkish)

* New translations file.inc.php (Russian)

* New translations file.inc.php (Portuguese)

* New translations file.inc.php (Polish)

* New translations file.inc.php (Dutch)

* New translations file.inc.php (Japanese)

* New translations setting.inc.php (Italian)

* New translations resource.inc.php (Italian)

* New translations propertyset.inc.php (Italian)

* New translations package_builder.inc.php (Italian)

* New translations default.inc.php (Ukrainian)

* New translations access.inc.php (Romanian)

* New translations access.inc.php (Hungarian)

* New translations access.inc.php (Chinese Simplified)

* New translations access.inc.php (Turkish)

* New translations access.inc.php (Swedish)

* New translations access.inc.php (Russian)

* New translations access.inc.php (Portuguese)

* New translations access.inc.php (Polish)

* New translations access.inc.php (Dutch)

* New translations access.inc.php (Japanese)

* New translations access.inc.php (Italian)

* New translations access.inc.php (Hebrew)

* New translations access.inc.php (Persian)

* New translations access.inc.php (Finnish)

* New translations access.inc.php (Greek)

* New translations access.inc.php (Danish)

* New translations access.inc.php (Czech)

* New translations access.inc.php (Bulgarian)

* New translations access.inc.php (Belarusian)

* New translations access.inc.php (Arabic)

* New translations access.inc.php (Spanish)

* New translations access.inc.php (French)

* New translations access.inc.php (Indonesian)

* New translations access.inc.php (Thai)

* New translations default.inc.php (Russian)

* New translations default.inc.php (German)

* New translations access.inc.php (Estonian)

* New translations default.inc.php (Belarusian)

* New translations default.inc.php (Spanish)

* New translations access.inc.php (Yoruba)

* New translations access.inc.php (Hindi)

* New translations file.inc.php (Yoruba)

* New translations access.inc.php (Hungarian)

* New translations default.inc.php (Hungarian)

* New translations access.inc.php (German)

* New translations file.inc.php (German)

* New translations file.inc.php (Hungarian)

* New translations file.inc.php (Russian)

* New translations resource.inc.php (Hungarian)

* New translations user.inc.php (Hungarian)
@Mark-H @opengeek
PHP8 compatibility for 3.x (modxcms#15421)
536b19b 
* Assorted PHP8 compatibility fixes (port from modxcms#15335 + c032c26)

* Convert PHPUnit using yoast/phpunit-polyfills so it will run in all supported releases

* Add @Medium to modDashboardTest::testRender()

Co-authored-by: Jason Coward <jason@opengeek.com>
@theboxer
Fix setup update process (modxcms#15399)
c3847ff
@Ruslan-Aleev @opengeek
Add check that the file exists when uploading it (modxcms#15264)
d463e3f 
* Added check that file exists when uploading it

* grunt build

Co-authored-by: Jason Coward <jason@opengeek.com>
@BobRay @JoshuaLuckers
Update modUser.php (modxcms#15376)
602b70c 
* Update modUser.php

Prevent PHP error when $_SESSION is not set (e.g., in a unit or acceptance test).

* Update core/src/Revolution/modUser.php

Co-authored-by: Joshua Lückers <joshualuckers@me.com>

Co-authored-by: Joshua Lückers <joshualuckers@me.com>
@BobRay
Avoid error if $_SESSION is not set (modxcms#15377)
df3edb0
@theboxer
Menu improvements (modxcms#15388)
730164c 
* Menu improvements

* Updates
@theboxer
Update user customized dashboards (modxcms#15390)
25bb10a
@modxbot
New Crowdin updates (modxcms#15419)
1dc912b 
* New translations access.inc.php (Russian)

* New translations dashboards.inc.php (Indonesian)

* New translations configcheck.inc.php (Ukrainian)

* New translations events.inc.php (Ukrainian)

* New translations formcustomization.inc.php (Ukrainian)

* New translations resource.inc.php (Ukrainian)

* New translations user.inc.php (Ukrainian)
@Ibochkarev
Fix PHP Fatal error: Uncaught Error: Call to a member function fromAr…
a2cdca3 
…ray() (modxcms#15436)
@sergant210
Fix user block checking on login.
bcb4788
@Ibochkarev
Update MODX logo and icon
945d82e
@Ruslan-Aleev
Fixed lexicon to correct one
0434941
@Mark-H
Fix incorrect lexicon when editing media source names [modxcms#15155]
46f84f2 
Merge remote-tracking branch 'upstream/pr/15447' into 3.x
@muzzwood
Switched class condition to MODX\Revolution\modPlugin
aba5e1e
@wax100
Fixed issue modxcms#15255 #modxbughunt
925b6ce
@sergant210
Fixed incorrect hour checks for the greeting message. (modxcms#15443)
46f0285
@sergant210
Update Login.php
7571ff3
@muzzwood
Updated class name on plugin panel
0a63db6
opengeek and others added 27 commits October 27, 2021 11:08
@opengeek
Update changelog for 3.0.0-alpha3 release
e90eae3
@opengeek
Bump version for 3.0.0-beta1
9398426
@opengeek
Update link to CLA in .github/CONTRIBUTING.md
718c3b7
Remove unused refreshTVs method (modxcms#15882)
fa3aaad
@modxbot
New Crowdin updates (modxcms#15874)
fcf8038 
* New translations tv.inc.php (Hindi)

* New translations tv_widget.inc.php (Hindi)

* New translations user.inc.php (Hindi)

* New translations login.inc.php (Hindi)

* New translations access.inc.php (Hindi)

* New translations access.inc.php (Hindi)
@Mark-H
Restrict static resources to predefined path (modxcms#15885)
0be5dbb 
* Restrict static resources to predefined path  (port of modxcms#15656 for 3.x, SEC-3801) 

* Use ::class syntax
@modxbot
New translations upgrades.inc.php (Hindi) (modxcms#15886)
ad810eb
@opengeek
Add zero-padded decimal option for number TVs (modxcms#15890)
e68bbdd 
* Port of 15840 to 3.x

* grunt build

Co-authored-by: Jason Coward <jason@opengeek.com>
@Ibochkarev
Configurable extension for static html files
342428e
@Ibochkarev @JoshuaLuckers
Update _build/data/transport.core.system_settings.php
46c74e5 
Co-authored-by: Joshua Lückers <joshualuckers@me.com>
@Ibochkarev @JoshuaLuckers
Update _build/data/transport.core.system_settings.php
fc2f3f5 
Co-authored-by: Joshua Lückers <joshualuckers@me.com>
@Jako
Remove superfluous lexicon entries (modxcms#15884)
345a5fb
@modxbot
New Crowdin updates (modxcms#15891)
08cb03d 
* New translations setting.inc.php (Hindi)

* New translations setting.inc.php (Japanese)

* New translations setting.inc.php (Estonian)

* New translations setting.inc.php (Thai)

* New translations setting.inc.php (Persian)

* New translations setting.inc.php (Indonesian)

* New translations setting.inc.php (Chinese Simplified)

* New translations setting.inc.php (Ukrainian)

* New translations setting.inc.php (Turkish)

* New translations setting.inc.php (Swedish)

* New translations setting.inc.php (Russian)

* New translations setting.inc.php (Portuguese)

* New translations setting.inc.php (Polish)

* New translations setting.inc.php (Dutch)

* New translations setting.inc.php (Italian)

* New translations setting.inc.php (Romanian)

* New translations setting.inc.php (Hungarian)

* New translations setting.inc.php (Hebrew)

* New translations setting.inc.php (Finnish)

* New translations setting.inc.php (Greek)

* New translations setting.inc.php (German)

* New translations setting.inc.php (Danish)

* New translations setting.inc.php (Czech)

* New translations setting.inc.php (Bulgarian)

* New translations setting.inc.php (Belarusian)

* New translations setting.inc.php (Arabic)

* New translations setting.inc.php (Spanish)

* New translations setting.inc.php (French)

* New translations setting.inc.php (Yoruba)

* New translations tv_widget.inc.php (German)

* New translations setting.inc.php (Czech)

* New translations tv_widget.inc.php (Hindi)

* New translations tv_widget.inc.php (Yoruba)

* New translations upgrades.inc.php (Hindi)

* New translations setting.inc.php (Romanian)

* New translations setting.inc.php (French)

* New translations setting.inc.php (Spanish)

* New translations setting.inc.php (Arabic)

* New translations setting.inc.php (Belarusian)

* New translations setting.inc.php (Bulgarian)

* New translations setting.inc.php (Danish)

* New translations tv_widget.inc.php (Thai)

* New translations setting.inc.php (German)

* New translations setting.inc.php (Greek)

* New translations setting.inc.php (Finnish)

* New translations setting.inc.php (Hebrew)

* New translations setting.inc.php (Hungarian)

* New translations setting.inc.php (Italian)

* New translations setting.inc.php (Japanese)

* New translations setting.inc.php (Dutch)

* New translations setting.inc.php (Polish)

* New translations setting.inc.php (Portuguese)

* New translations tv_widget.inc.php (Estonian)

* New translations tv_widget.inc.php (Persian)

* New translations setting.inc.php (Hindi)

* New translations tv_widget.inc.php (Hebrew)

* New translations tv_widget.inc.php (Romanian)

* New translations tv_widget.inc.php (French)

* New translations tv_widget.inc.php (Spanish)

* New translations tv_widget.inc.php (Arabic)

* New translations tv_widget.inc.php (Belarusian)

* New translations tv_widget.inc.php (Bulgarian)

* New translations tv_widget.inc.php (Czech)

* New translations tv_widget.inc.php (Danish)

* New translations tv_widget.inc.php (Greek)

* New translations tv_widget.inc.php (Finnish)

* New translations tv_widget.inc.php (Hungarian)

* New translations tv_widget.inc.php (Indonesian)

* New translations tv_widget.inc.php (Italian)

* New translations tv_widget.inc.php (Japanese)

* New translations tv_widget.inc.php (Dutch)

* New translations tv_widget.inc.php (Polish)

* New translations tv_widget.inc.php (Portuguese)

* New translations tv_widget.inc.php (Russian)

* New translations tv_widget.inc.php (Swedish)

* New translations tv_widget.inc.php (Turkish)

* New translations tv_widget.inc.php (Ukrainian)

* New translations tv_widget.inc.php (Chinese Simplified)

* New translations setting.inc.php (Russian)

* New translations setting.inc.php (Swedish)

* New translations policy.inc.php (Italian)

* New translations system_events.inc.php (Italian)

* New translations tv.inc.php (Italian)

* New translations default.inc.php (Italian)

* New translations element.inc.php (Italian)

* New translations setting.inc.php (Turkish)

* New translations setting.inc.php (Ukrainian)

* New translations setting.inc.php (Chinese Simplified)

* New translations setting.inc.php (Indonesian)

* New translations setting.inc.php (Persian)

* New translations setting.inc.php (Thai)

* New translations setting.inc.php (Estonian)

* New translations setting.inc.php (Yoruba)

* New translations tv_widget.inc.php (Italian)

* New translations formcustomization.inc.php (Hindi)
Fix problems in lexicon creation form (modxcms#15892)
5b11f19 
* Updates to address issue modxcms#15223

* Update Create.php

* Alter trimming of data to exclude value field
@opengeek
Update changelog for 3.0.0-beta1
413076b
@opengeek
Bump version for 3.0.0-beta2 development cycle
a022ee6
@modxbot
New Crowdin updates (modxcms#15896)
e801380 
* New translations tv_widget.inc.php (Danish)

* New translations tv_widget.inc.php (Czech)

* New translations tv_widget.inc.php (Bulgarian)

* New translations tv_widget.inc.php (Belarusian)

* New translations tv_widget.inc.php (Arabic)

* New translations tv_widget.inc.php (Spanish)

* New translations tv_widget.inc.php (French)

* New translations tv_widget.inc.php (Romanian)

* New translations tv_widget.inc.php (Yoruba)

* New translations tv_widget.inc.php (Hindi)

* New translations tv_widget.inc.php (German)

* New translations tv_widget.inc.php (Thai)

* New translations tv_widget.inc.php (Estonian)

* New translations tv_widget.inc.php (Turkish)

* New translations tv_widget.inc.php (Persian)

* New translations tv_widget.inc.php (Dutch)

* New translations tv_widget.inc.php (Greek)

* New translations tv_widget.inc.php (Finnish)

* New translations tv_widget.inc.php (Hebrew)

* New translations tv_widget.inc.php (Hungarian)

* New translations tv_widget.inc.php (Italian)

* New translations tv_widget.inc.php (Japanese)

* New translations tv_widget.inc.php (Polish)

* New translations tv_widget.inc.php (Indonesian)

* New translations tv_widget.inc.php (Portuguese)

* New translations tv_widget.inc.php (Russian)

* New translations tv_widget.inc.php (Swedish)

* New translations tv_widget.inc.php (Ukrainian)

* New translations tv_widget.inc.php (Chinese Simplified)

* New translations tv_input_types.inc.php (German)
@modxbot
New Crowdin updates (modxcms#15899)
14b3fd5 
* New translations tv_widget.inc.php (Russian)

* New translations tv_widget.inc.php (Ukrainian)

* New translations setting.inc.php (Russian)

* New translations setting.inc.php (Ukrainian)

* New translations access.inc.php (Ukrainian)

* New translations file.inc.php (Ukrainian)

* New translations formcustomization.inc.php (Ukrainian)

* New translations access.inc.php (Hindi)

* New translations upgrades.inc.php (Hindi)

* New translations source.inc.php (Hindi)

* New translations trash.inc.php (Hindi)

* New translations default.inc.php (Hindi)

* New translations setting.inc.php (Hindi)

* New translations menu.inc.php (Hindi)

* New translations topmenu.inc.php (Hindi)

* New translations system_events.inc.php (Hindi)

* New translations source.inc.php (Hindi)

* New translations snippet.inc.php (Hindi)

* New translations propertyset.inc.php (Hindi)

* New translations policy.inc.php (Hindi)

* New translations permissions.inc.php (Hindi)

* New translations languages.inc.php (Hindi)

* New translations access.inc.php (Hindi)

* New translations file.inc.php (Hindi)

* New translations element.inc.php (Hindi)

* New translations default.inc.php (Hindi)

* New translations dashboards.inc.php (Hindi)

* New translations resource.inc.php (Hindi)

* New translations login.inc.php (Hindi)

* New translations tv_widget.inc.php (Hindi)

* New translations tv.inc.php (Hindi)

* New translations workspace.inc.php (Hindi)

* New translations tv_widget.inc.php (Swedish)

* New translations login.inc.php (Hindi)

* New translations setting.inc.php (Swedish)

* New translations element.inc.php (Hindi)

* New translations messages.inc.php (Hindi)

* New translations permissions.inc.php (Hindi)

* New translations plugin.inc.php (Hindi)

* New translations policy.inc.php (Hindi)

* New translations setting.inc.php (Hindi)

* New translations tv.inc.php (Hindi)

* New translations tv_widget.inc.php (Hindi)

* New translations resource.inc.php (Hindi)

* New translations formcustomization.inc.php (Hindi)

* New translations default.inc.php (Hindi)

* New translations events.inc.php (Hindi)

* New translations file.inc.php (Hindi)

* New translations policy.inc.php (Hindi)

* New translations propertyset.inc.php (Hindi)

* New translations rest.inc.php (Hindi)

* New translations source.inc.php (Hindi)

* New translations system_events.inc.php (Hindi)

* New translations setting.inc.php (Hindi)

* New translations configcheck.inc.php (Hindi)

* New translations workspace.inc.php (Hindi)

* New translations trash.inc.php (Hindi)

* New translations policy.inc.php (Hindi)

* New translations default.inc.php (Hindi)

* New translations dashboards.inc.php (Hindi)

* New translations content_type.inc.php (Hindi)

* New translations action.inc.php (Hindi)

* New translations access.inc.php (Hindi)

* New translations about.inc.php (Hindi)

* New translations formcustomization.inc.php (Hindi)

* New translations upgrades.inc.php (Hindi)

* New translations user.inc.php (Hindi)

* New translations tv_widget.inc.php (Hindi)

* New translations tv.inc.php (Hindi)

* New translations default.inc.php (Hindi)
@Mark-H
Fix isBinary check (modxcms#15901)
e79da1b 
This adds a whitelist of mime types that should be editable.

Also corrects the logic for calls to isFileBinary; a binary file is one that consists of garbage text and should not be edited, but that logic had been flipped in 3.x.
@JoshuaLuckers
Remove unused processor Security/User/Group/GetList (modxcms#15910)
7654046 
* Remove unused processor Security/User/Group/GetList

* Reformat code to fix phpcs errors
@modxbot
New Crowdin updates (modxcms#15906)
dbfb69b 
* New translations setting.inc.php (Hindi)

* New translations user.inc.php (Hindi)

* New translations upgrades.inc.php (Hindi)

* New translations source.inc.php (Hindi)

* New translations workspace.inc.php (Hindi)
@Ruslan-Aleev @opengeek
Change order of Directory/File menu items in tree (modxcms#15759)
b922a44 
* Change order of menu items for Files in tree

* Added delimiter for remove item in context menu for Contexts / Elements

* grunt build

Co-authored-by: Jason Coward <jason@opengeek.com>
@opengeek
Update changelog for 3.0.0-beta2
d4c1e5e
@opengeek
Bump version for rc1 development cycle
d96badf
@Ibochkarev
Add missing Static Resources lexicon key (modxcms#15931)
5993cb9 
* Added missing lexicon key

* Added missing lexicon key
@modxbot
New Crowdin updates (modxcms#15917)
7625fc7 
* New translations file.inc.php (Ukrainian)

* New translations file.inc.php (Italian)

* New translations file.inc.php (Persian)

* New translations file.inc.php (Indonesian)

* New translations file.inc.php (Chinese Simplified)

* New translations file.inc.php (Turkish)

* New translations file.inc.php (Swedish)

* New translations file.inc.php (Russian)

* New translations file.inc.php (Portuguese)

* New translations file.inc.php (Polish)

* New translations file.inc.php (Dutch)

* New translations file.inc.php (Japanese)

* New translations file.inc.php (Hungarian)

* New translations file.inc.php (Hebrew)

* New translations file.inc.php (Finnish)

* New translations file.inc.php (Greek)

* New translations file.inc.php (German)

* New translations file.inc.php (Danish)

* New translations file.inc.php (Czech)

* New translations file.inc.php (Bulgarian)

* New translations file.inc.php (Belarusian)

* New translations file.inc.php (Arabic)

* New translations file.inc.php (Spanish)

* New translations file.inc.php (French)

* New translations file.inc.php (Romanian)

* New translations file.inc.php (Hindi)

* New translations file.inc.php (Thai)

* New translations file.inc.php (Estonian)

* New translations file.inc.php (Yoruba)

* New translations file.inc.php (Hungarian)

* New translations resource.inc.php (Hungarian)

* New translations tv.inc.php (Hungarian)

* New translations about.inc.php (Polish)

* New translations tv_widget.inc.php (Hungarian)
@theboxer
Fix FC Set's update from grid processor to adjust only fields passed …
be84424 
…from grid
@theboxer theboxer closed this Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mark-H Mark-H Awaiting requested review from Mark-H Mark-H is a code owner

@opengeek opengeek Awaiting requested review from opengeek opengeek is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone