Added remembering filter properties of deleted resources grid in browser url #15946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruslan-Aleev
added
pr/review-needed
Ruslan-Aleev
commented
Dec 28, 2021
theboxer
approved these changes
Jan 4, 2022
|
@GulomovCreative @Ruslan-Aleev keep your comments in english, others might want to read them as well. |
GulomovCreative
suggested changes
Jan 19, 2022
GulomovCreative
approved these changes
Jan 19, 2022
Ruslan-Aleev
added
pr/ready-for-merging
This was referenced Feb 25, 2022
opengeek
removed
the
pr/ready-for-merging
Mark-H
requested changes
Jan 26, 2023
| if ($deleted = $this->getDeleted()) { | ||
| $c->where(['modResource.id:IN' => $deleted]); | ||
| } else { | ||
| return; |
There was a problem hiding this comment.
prepareQueryBeforeCount() must always return the xPDOQuery
There was a problem hiding this comment.
And what kind of where to put here, so as not to return anything? Will this one work?
$c->where(['modResource.id' => 0]);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
In the trash, it was possible to find an undeleted resource (any resource from the tree) through a search :)
The relationship between the deleted parent and the undeleted child resources will be a little clearer. Because many resources are not deleted but appear in the grid and will be deleted due to the parent being deleted.
Why is it needed?
Allow to copy/paste the state of the filter with the browser url.
Related issue(s)/PR(s)
#15942
#15935
#15186
#15185
#15184
#15183
#15182
#15181
#15115
#14086