Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remembering filter properties of template TVs grid in browser url #16063

Closed
wants to merge 1 commit into from
Closed

Add remembering filter properties of template TVs grid in browser url #16063

wants to merge 1 commit into from

Conversation

Ruslan-Aleev
Copy link
Collaborator

What does it do?

  • Added the selected filter properties in the browser url.

tpl_tv_url

Why is it needed?

Allow to copy/paste the state of the filter with the browser url.

Related issue(s)/PR(s)

#15946
#15942
#15935
#15186
#15185
#15184
#15183
#15182
#15181
#15115
#14086

@cla-bot cla-bot bot added the cla-signed CLA confirmed for contributors to this PR. label Feb 18, 2022
@Ruslan-Aleev Ruslan-Aleev added pr/review-needed Pull request requires review and testing. type-frontend Issues related to UI/UX issues, mostly about styles and frontend implementations on JavaScript. labels Feb 18, 2022
@Ruslan-Aleev Ruslan-Aleev added this to the v3.1.0 milestone Feb 18, 2022
@smg6511
Copy link
Collaborator

smg6511 commented Mar 6, 2022

@Ruslan-Aleev - Sorry it has taken so long for me to look at these as promised a while ago. I'm attaching a couple files with a more consolidated strategy for you to consider for this and the other grid filtering PRs you've been working on. I'm attaching instead of trying to comment on them inline here because it'll probably be much easier to see what I'm suggesting by just doing a diff on your end. Anyway, the main thing I'm doing here is taking advantage of class inheritance and the fact that the filtering and clearing of filters are doing essentially the same task over and over across all the grids. We don't need a method in every grid for these tasks, so I've created a couple methods in the base grid class. Take a look and let me know what you think...

grid-files.zip

Also, haven't forgotten that the other important thing you were wanting help on was providing the ability to activate the correct tab easily and in a global manner. I'll be able to focus on that a bit over the next couple weeks.

UPDATE: I actually was able to develop something to handle the tabs as well, and am just working out the more difficult area where there are both horizontal and vertical tabs (I think the ACL user group area is the only place this happens). Anyway, hold off on incorporating the methods I created in the main grid file (attached above) as I've built on those a little bit.

@Ruslan-Aleev
Copy link
Collaborator Author

Ruslan-Aleev commented Mar 10, 2022

@smg6511 Thank you for your work! I'm sorry I didn't write earlier.
Could you send your code as a separate PR? So that those who understand better in js could also comment.
Unfortunately, I don't have the opportunity to test it yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA confirmed for contributors to this PR. pr/review-needed Pull request requires review and testing. type-frontend Issues related to UI/UX issues, mostly about styles and frontend implementations on JavaScript.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants