Revisit EIP1167 for IPNFT Tokenization #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP: Revisit EIP1167 for IPNFT Tokenization
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
elmariachi111
requested changes
Jan 10, 2024
test/Tokenizer.t.sol
Outdated
|
|
||
| vm.startPrank(mainnetOwner); // Owner address on mainnet | ||
| tokenizer11 = Tokenizer11(mainnetTokenizer); | ||
| tokenizer11.upgradeTo(address(new Tokenizer())); |
There was a problem hiding this comment.
what's a little dangerous here is that the Tokenizer's IPToken implementation is undefined between these two transactions. I'm wondering if upgradeToAndCall might help (calling the setIPTokenImplementation during the upgrade step)
polus-arcticus
changed the title
elmariachi111
force-pushed
the
feature/eip-1167
branch
3 times, most recently
from
d7582cf to
fb6c882
Compare
elmariachi111
force-pushed
the
feature/eip-1167
branch
2 times, most recently
from
dd56cac to
ab49b7e
Compare
polus-arcticus
commented
Jan 17, 2024
src/Tokenizer.sol
Outdated
| @@ -27,12 +27,18 @@ contract Tokenizer is UUPSUpgradeable, OwnableUpgradeable { | |||
| string symbol | |||
| ); | |||
|
|
|||
| event IPTokenUpgraded( | |||
| address indexed oldAddress, | |||
| address indexed newAddress | |||
There was a problem hiding this comment.
Could include version number for brevity
test/Tokenizer.t.sol
Outdated
| tokenizer = Tokenizer(address(new ERC1967Proxy(address(new Tokenizer()), ""))); | ||
| tokenizer.initialize(ipnft, blindPermissioner); | ||
| tokenizer.setIPTokenImplementation(address(ipToken)); |
There was a problem hiding this comment.
Could be placed inside the initialise function as well
src/Tokenizer.sol
Outdated
| /** | ||
| * @dev called after an upgrade to reinitialize a new permissioner impl. This is 4 for görli compatibility | ||
| * @param _permissioner the new TermsPermissioner | ||
| */ | ||
| function reinit(IPermissioner _permissioner) public onlyOwner reinitializer(4) { | ||
| function reinit(IPermissioner _permissioner) public onlyOwner reinitializer(5) { |
There was a problem hiding this comment.
This needed to be bumped one to set the blind permissioner
elmariachi111
force-pushed
the
feature/eip-1167
branch
from
5060c6b to
5753c04
Compare
…izer attempting to upgrade tokenizer
forgot console import
fixes old tests configures gh env vars to run the tests cleans up some comments, tokenizer version bump hardhat test command add in ignore comment
* adds a setter for the permissioner * uses contracts instead of addresses * adds a address(0) check to setters Signed-off-by: stadolf <stefan@molecule.to> --------- Signed-off-by: stadolf <stefan@molecule.to>
readded ignore comment settable permissioners / revert reinit (#150) * adds a setter for the permissioner * uses contracts instead of addresses * adds a address(0) check to setters Signed-off-by: stadolf <stefan@molecule.to> --------- Signed-off-by: stadolf <stefan@molecule.to>
mocks it by code injection instead Signed-off-by: stadolf <stefan@molecule.to>
pseudo code for upgrade minimal changes to upgradetokenizer natspec / whitespace updates Signed-off-by: stadolf <stefan@molecule.to>
impl in readme more README :) Signed-off-by: stadolf <stefan@molecule.to>
updates new addresses Signed-off-by: stadolf <stefan@molecule.to>
Signed-off-by: stadolf <stefan@molecule.to>
strips down unnecessary initialization code reinits real permissioner on crowdsale test again Signed-off-by: stadolf <stefan@molecule.to>
new mainnet iptoken impl address Signed-off-by: stadolf <stefan@molecule.to>
elmariachi111
force-pushed
the
feature/eip-1167
branch
from
755a5ef to
4a77522
Compare
elmariachi111
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.notion.so/moleculeto/revisit-EIP1167-for-IPNFT-Tokenization-ceaaa1f64c024d12a8ba402bc109ee6e