-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EMC update 20210322 #1357
EMC update 20210322 #1357
Conversation
merge dev/emc
merge dev/emc
merge to latest dev/emc
Feature/logcleanup (#20)
nuopc_driver updates (mom-ocean#22)
- In A and B grid configuration halos were never updated after taux/tauy were populated. - This propogated through to the ustar_gustless field, hence caused a restart issue when using ustar_gustless in parameterizations. - This appears to correct the restart issue by updating the halos at the end of the A and B grid taux/tauy loops.
…s_in_nupoc Add two halo updates for taux and tauy in mom_surface_forcing_nuopc
…20210120 This is corresponding GFDL 20210120 main branch commit (hash # fe5e605)
…120' into bugfix/li2016fix skip-ci
This patch fixes a sign bug, in both MCT and NUOPC, when accounting for the latent heat from fprec and frunnoff. Following MOM6's definition, both fprec and frunoff are > 0 into the ocean. Therefore, the latent heat associated with these terms should be negative.
Bugfix: sign error on fprec for nuopc and mct caps
…L-20210120 Feature/update to gfdl 20210120
* read config variable 'use_mommesh' in ufs; default is false to have mom cap run on grid
Allow MOM6 to use a mesh optionally
…update-to-GFDL-20210224 this is corresponding to GFDL 20210224 main branch commit (hash # 00c2819)
…L-20210224 Feature/update to gfdl 20210224
…20210308 this is corresponding to GFDL 20210308 main branch commit (hash # a4049e7)
* if true, allow the topog overrides to change the land mask
…L-20210308 Feature/update to gfdl 20210308
https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/12325 ✔️ 🟡 This has passed but will require a parameter file update ( |
@gustavo-marques Do you mind quickly reviewing this? I am going to send it to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an answer-changing bug fix in the sign of frozen precipitation contributions to the latent heat fluxes, and I agree that this is a bug. We need to either get explicit buy-in from absolutely everyone that they want the code to irretrievably change answers using the mct and nuopc caps, without the ability to recreate the current answers, or we need to use a run-time flag to correct this bug.
If there any published papers that use the current (buggy) version, or even experimental runs that people find interesting, I strongly suspect that we will need a run-time bug-fix flag for these changes, and the default at first should be to keep the bug. We can move aggressively to change the default, and then more deliberately to obsolete and eliminate the bug-fix flag.
@marshallward In your branch, here rho is not defined as optional, but in you removed rho @marshallward sorry the above might be a false alarm, I was not looking at the right subroutine in CVmixing |
@jiandewang |
This PR is changing answers for us but I do not believe the reason is the bug fixes in MCT and NUOPC. The answer-changing bug fixes are already implemented in dev/ncar (NCAR#174). We have notified, ~ 2 months ago, people that we know are affected by these changes. They were all okay with them. We need to do a more thorough evaluation to find out what commit(s) is(are) changing answers. I will start by evaluating dev/gfdl. In terms of the changes being proposed here, I approve this PR. |
@gustavo-marques let me also try dev/gfdl in UFS. (BTW, I will be out of town 27-31, so no need to be hurry) |
Thanks @gustavo-marques @jiandewang @jiandewang : I'd like to merge this into I don't mind waiting if you prefer, but you will also get a chance to test this during the |
@marshallward then do as you planned |
Great, thanks all. We will merge this to |
I am withdrawing my requested changes because everyone we are aware of who might be using the NUOPC or MCT couplers has indicated that they are on-board with these changes, some of which are already on the dev/ncar branch. |
We have had an indication that everyone who might be using this code is OK with this bug-fix, without introducing a run-time flag to recreate the bug.
This PR is an update from EMC courtesy of @jiandewang.
We are merging this directly into
dev/gfdl
due to a mistake on our part where we prematurely mergeddev/gfdl
intomain
. These premature unreviewed commits ended up indev/emc
fork before we detected our mistake. Once approved for merge intodev/gfdl
, we will then submit this tomain
for review ASAP.Summary of changes (provided by @jiandewang):