add command pop_blocks monerod #4903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiphon
reviewed
Nov 25, 2018
xiphon
reviewed
Nov 25, 2018
xiphon
reviewed
Nov 25, 2018
| try | ||
| { | ||
| uint64_t nblocks = boost::lexical_cast<uint64_t>(args[0]); | ||
| if (nblocks < 1) { |
There was a problem hiding this comment.
Please keep the same brace style as the code you're modifying, and consistent within the patch. Most code has the brace on a new line, and half your code here also does.
moneromooo-monero
approved these changes
Nov 27, 2018
|
Please squash |
add new public method to Blockchain and update according to code review update after review: better lock/unlock, try catch and coding style
Jasonhcwong
force-pushed
the
pop_blocks_in_monerod
branch
from
4d92676
to
dc1c125
Compare
|
did I do the squash correctly? |
moneromooo-monero
approved these changes
Nov 28, 2018
fluffypony
added a commit
that referenced
this pull request
Dec 12, 2018
dc1c125 add command pop_blocks (Jason Wong)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request adds a command "pop_blocks " to monerod.