GCC 9.1 fixes /monero#5613+#5865 #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCC wants operator= aand copy ctor to be both defined, or neither
It was removed, but it still accepted by the compiler, which warns for every file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
monero-project#5613
monero-project#5865
Two of the five total commits monero-project@2cbe756 and monero-project@11f13da were omitted due to the Aeon codebase not keeping up with Monero's recent updates.
Also, the second commit monero-project@35c20c4 was adapted so that nonexistent fields (
connection_context_base::m_sslandABPkeys::is_change_addressandABPkeys::additional_key) are removed.I'm leaving links to relevant upstream PRs that are to be taken in the future to hint the eventual patch creator (likely myself) that additional care is needed: