Warning fixes #5865
Merged
Warning fixes #5865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtnerd
reviewed
Aug 29, 2019
| @@ -4383,7 +4383,7 @@ boost::optional<epee::wipeable_string> simple_wallet::new_wallet(const boost::pr | |||
| } | |||
| success_msg_writer() << "**********************************************************************"; | |||
|
|
|||
| return std::move(password); | |||
| return password; | |||
There was a problem hiding this comment.
These should've been return {std::move(password)};, although a quick disassembly shows the the compiler treats it the same.
vtnerd
reviewed
Aug 29, 2019
| @@ -627,9 +627,10 @@ void Blockchain::pop_blocks(uint64_t nblocks) | |||
| const uint64_t blockchain_height = m_db->height(); | |||
| if (blockchain_height > 0) | |||
| nblocks = std::min(nblocks, blockchain_height - 1); | |||
| for (i=0; i < nblocks; ++i) | |||
| while (i < nblocks) | |||
There was a problem hiding this comment.
Didn't like for ( ; i < nblocks; ++i) ?
There was a problem hiding this comment.
I do not think I tried that.
vtnerd
approved these changes
Aug 29, 2019
aeonix
added a commit
to aeonix/aeon
that referenced
this pull request
Sep 23, 2019
GCC 9.1 fixes /monero#5613+monero-project#5865
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.