Nano-S fixes for v0.14 #5132
Nano-S fixes for v0.14 #5132
Conversation
cslashm
commented
Feb 8, 2019
cslashm
commented
- New management of destination keys and their verification by user
- next V10 protocol support
- some debug fixes
cslashm
changed the title
cslashm
changed the title
| @@ -1479,20 +1489,31 @@ namespace hw { | |||
| offset+=32; | |||
| } else { | |||
| // dummy: is_subaddress Aout Bout AKout | |||
| offset += 1+32*3; | |||
| offset += 2+32*3; | |||
There was a problem hiding this comment.
Why is this change for ?
There was a problem hiding this comment.
one more byte for is_change_address in the if counterpart , comment was not updated...
There was a problem hiding this comment.
Hmm, OK, I don't see a code change to add that extra byte, that's what I was getting at.
|
Will this be for 0.14 or 0.14.1? |
|
need to be for 0.14, else Ledger HW will not work |
|
Oh, thanks, I'd forgot about this. Can someone who has a ledger please test this ? |
|
What do you have left to do on this to lose the DO NOT MERGE part ? |
|
I have to check tow more things to ensure a "smooth" update between 0.13->0.14 with next Ledger app 1.2.0. It will be done this week. Then I will remove the "do not merge." |
cslashm
changed the title
|
Since you removed the do not merge now, can I assume you've tested and it's good to go ? |
|
I made:
Seems good so. |
|
When the testnet will move to v10? |
|
Probably a day or two after everything's ready. Everything here means just the final PoW. |
@moneromooo-monero I can give it a spin on my testing Ledger tomorrow. Will report back. |
