GCC 9.1 fixes #5613
Merged
GCC 9.1 fixes #5613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCC wants operator= aand copy ctor to be both defined, or neither
moneromooo-monero
force-pushed
the
gcc-9.1
branch
from
a2c9ec3
to
35c20c4
Compare
It was removed, but it still accepted by the compiler, which warns for every file
hyc
approved these changes
Jun 11, 2019
| @@ -134,10 +134,11 @@ namespace boost | |||
| a & port; | |||
| a & length; | |||
|
|
|||
| if (length > net::tor_address::buffer_size()) | |||
| const size_t buffer_size = net::tor_address::buffer_size(); | |||
| if (length > buffer_size) | |||
There was a problem hiding this comment.
For reference, we reported this bug upstream https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90825
hyc
approved these changes
Jun 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.