This repository has been archived by the owner on May 17, 2021. It is now read-only.
dont use ES6 syntax in grammar #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In c8b9e2 we removed transpilation to ES5, which broke Charts e2e tests.
Co-Authored-By: Scott Sidwell <38820281+scottsidwell@users.noreply.github.com>
imlucas
approved these changes
Jan 29, 2020
|
📦 |
|
Restarted last travis job. https://travis-ci.com/10gen/charts/builds/146618819 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In c8b9e2 we removed transpilation to ES5, which broke Charts e2e tests. There are only two places where we use ES6 syntax. This PR replaces them with ES5 compatible code.
To test locally for Charts, you can
yarn linkthis module, thenyarn link mongodb-language-modelfrom the charts root folder. Then build and run the e2e tests. Before this change, they would fail on the very first test with a blank screen and errorUncaught SyntaxError: Unexpected token ...in the dev console.This PR can be merged and released as 1.6.1 after Charts and Compass have reviewed and approved.