This repository has been archived by the owner on May 17, 2021. It is now read-only.
ci: Add node 10 to travis matrix for charts #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for raising this Lucas 🙂 The underlying issue arose not from our version of Node (10), but the version of Chromium/Electron was using when running Cypress tests (cypress-io/cypress#2069) which lacked spread/ES6 features. It’ll be good to have this check to catch similar errors in the future, but it doesn’t guarantee the published pkg bundle is ES5 compatible which was the underlying root cause (something like https://github.com/dollarshaveclub/es-check might be useful to enforce this, but also probably overkill 🙃) |
imlucas
added a commit
to mongodb-js/metrics
that referenced
this pull request
Jan 31, 2020
imlucas
added a commit
to mongodb-js/metrics
that referenced
this pull request
Jan 31, 2020
* build(deps-dev): Bump mongodb-js-precommit from 2.1.0 to 2.2.0 Bumps [mongodb-js-precommit](https://github.com/mongodb-js/precommit) from 2.1.0 to 2.2.0. - [Release notes](https://github.com/mongodb-js/precommit/releases) - [Commits](mongodb-js/precommit@v2.1.0...v2.2.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * chore: Fix all long lived lint errors * chore: normalize travis per mongodb-js/mongodb-language-model#22 Co-authored-by: Lucas Hrabovsky <hrabovsky.lucas@gmail.com>
gribnoysup
pushed a commit
to mongodb-js/compass
that referenced
this pull request
Apr 26, 2021
* build(deps-dev): Bump mongodb-js-precommit from 2.1.0 to 2.2.0 Bumps [mongodb-js-precommit](https://github.com/mongodb-js/precommit) from 2.1.0 to 2.2.0. - [Release notes](https://github.com/mongodb-js/precommit/releases) - [Commits](mongodb-js/precommit@v2.1.0...v2.2.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * chore: Fix all long lived lint errors * chore: normalize travis per mongodb-js/mongodb-language-model#22 Co-authored-by: Lucas Hrabovsky <hrabovsky.lucas@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so we avoid breaks like #21 in the future