Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): filter for explictily set variants in unit tests #2271

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

gagik
Copy link
Contributor

@gagik gagik commented Nov 21, 2024

Current setup led to multiple platform unit tests even for those such as browser-repl which have variants explicitly set to only 1 OS. This filters them again.

@gagik gagik added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Nov 21, 2024
@gagik gagik marked this pull request as ready for review November 21, 2024 14:06
@gagik gagik changed the title chore: filter for explictily set variants chore: filter for explictily set variants in unit tests Nov 21, 2024
@gagik gagik requested a review from nirinchev November 21, 2024 14:11
@addaleax addaleax changed the title chore: filter for explictily set variants in unit tests chore(ci): filter for explictily set variants in unit tests Nov 21, 2024
@gagik gagik merged commit 3ee446a into main Nov 21, 2024
17 of 18 checks passed
@gagik gagik deleted the gagik/filter-set-variants branch November 21, 2024 14:33
nirinchev added a commit that referenced this pull request Dec 2, 2024
* main: (34 commits)
  chore: update auto-generated files [skip actions]
  chore: update auto-generated files [skip actions]
  chore(ci): use github app tokens instead of bot user (#2282)
  chore: update auto-generated files [skip actions]
  chore(ci): cleanup auto generated file workflow MONGOSH-1927 (#2281)
  chore: update auto-generated files
  chore(ci): use a github app for the generated files credentials MONGOSH-1927 (#2280)
  chore(deps): bump driver, bson, oidc-plugin to latest MONGOSH-1916 (#2279)
  chore(ci): login to docker (#2277)
  chore(ci): don't download chrome for cron tasks (#2278)
  chore: update node.js (#2270)
  chore: push auto-generated files directly instead of using PRs (#2275)
  fix(ci): allocate more memory to fix test_vscode MONGOSH-1892 (#2239)
  chore: update auto-generated files (#2276)
  feat(shell-api): add options in stream processor start, stop, and drop MONGOSH-1920 (#2274)
  chore: update auto-generated files (#2273)
  chore: update auto-generated files (#2272)
  fix: include nonce in oidc request by default MONGOSH-1905 MONGOSH-1917 (#2269)
  chore(ci): filter for explictily set variants in unit tests (#2271)
  chore: update auto-generated files (#2268)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants