feat(shell-api): add options in stream processor start, stop, and drop MONGOSH-1920 #2274
Conversation
mongodb-matthew-normyle
commented
Nov 22, 2024
•
mongodb-matthew-normyle
commented
- Add an options parameter to the stream processor start, stop, and drop methods. We already do this for sample and stats methods.
- This allows Atlas Stream Processing to support features like STREAMS-872.
There was a problem hiding this comment.
LGTM – we probably should have done this from the beginning, it matches what similar helpers do in the mongosh API. The fact that, in some versions of mongosh, options will silently be ignored and, in newer versions, will be applied is probably going to trip up a couple users but I also don't really know a better way forward than to just add these and accept that.
Noted. We will clarify in streams documentation that various new features (i.e. support for |
* main: (34 commits) chore: update auto-generated files [skip actions] chore: update auto-generated files [skip actions] chore(ci): use github app tokens instead of bot user (#2282) chore: update auto-generated files [skip actions] chore(ci): cleanup auto generated file workflow MONGOSH-1927 (#2281) chore: update auto-generated files chore(ci): use a github app for the generated files credentials MONGOSH-1927 (#2280) chore(deps): bump driver, bson, oidc-plugin to latest MONGOSH-1916 (#2279) chore(ci): login to docker (#2277) chore(ci): don't download chrome for cron tasks (#2278) chore: update node.js (#2270) chore: push auto-generated files directly instead of using PRs (#2275) fix(ci): allocate more memory to fix test_vscode MONGOSH-1892 (#2239) chore: update auto-generated files (#2276) feat(shell-api): add options in stream processor start, stop, and drop MONGOSH-1920 (#2274) chore: update auto-generated files (#2273) chore: update auto-generated files (#2272) fix: include nonce in oidc request by default MONGOSH-1905 MONGOSH-1917 (#2269) chore(ci): filter for explictily set variants in unit tests (#2271) chore: update auto-generated files (#2268) ...
