GODRIVER-1923 Error if BSON cstrings contain null bytes #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divjotarora
force-pushed
the
godriver1923-bson-cstrings
branch
from
93e724c to
78b349d
Compare
divjotarora
changed the title
kevinAlbs
approved these changes
Mar 25, 2021
iwysiu
reviewed
Mar 25, 2021
divjotarora
commented
Mar 25, 2021
iwysiu
approved these changes
Mar 25, 2021
kevinAlbs
reviewed
Mar 29, 2021
divjotarora
pushed a commit
that referenced
this pull request
Mar 29, 2021
tolsen
pushed a commit
to tolsen/mongo-go-driver
that referenced
this pull request
Jun 10, 2021
iwysiu
pushed a commit
that referenced
this pull request
Jun 10, 2021
iwysiu
pushed a commit
to iwysiu/mongo-go-driver
that referenced
this pull request
Jun 11, 2021
iwysiu
added a commit
that referenced
this pull request
Jun 14, 2021
Co-authored-by: Divjot Arora <divjot.arora@10gen.com>
kevinAlbs
pushed a commit
to kevinAlbs/mongo-go-driver
that referenced
this pull request
Aug 11, 2021
…mongodb#684) Co-authored-by: Divjot Arora <divjot.arora@10gen.com>
faem
pushed a commit
to kubedb/mongo-go-driver
that referenced
this pull request
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per bsonspec.org, cstrings are only used for BSON key names and for the pattern/options fields in a BSON regex value so this PR applies validation to those types. This validation does not apply to regular BSON strings, which can have null bytes because they're prefixed with a 4-byte length. It also does not apply to extended JSON because the JSON specification allows null bytes and other unicode code points as long as they are properly escaped (e.g. in JSON, this would look like
{"foo\u0000": "bar"}.