GODRIVER-1923 Error if BSON cstrings contain null bytes (#622) #684
Conversation
There was a problem hiding this comment.
LGTM. Just compared with the release/1.4 backport and saw one extra change (seems harmless). Should you mark GODRIVER-1923 with release version 1.3.8?
For full intellectual honesty, you should probably compare it with the one linked up top, since I actually made a minor change to the 1.4 backport and forgot to file a pull request for it. this contains both the 1.4 and 1.3 backport changes, though. |
|
|
||
| t.Run("element keys", func(t *testing.T) { | ||
| createDocFn := func() { | ||
| BuildDocument(nil, AppendStringElement(nil, "a\x00", "foo")) |
There was a problem hiding this comment.
Thanks for pointing out the minor change from the commit on master here. Looks like NewDocumentBuilder is not available until 1.5.0 with GODRIVER-613.
LGTM even more, and no need to mark as 1.3.8 since we won't release on 1.3.
There was a problem hiding this comment.
LGTM!
LGTM. Just compared with the release/1.4 backport and saw one extra change (seems harmless). Should you mark GODRIVER-1923 with release version 1.3.8?
Good question, I will check if a release is required. If it is, we may need to do a 1.3.8 and 1.4.8 release.
…mongodb#684) Co-authored-by: Divjot Arora <divjot.arora@10gen.com>
Because I had to make a few changes to backport it: 2aca31d