DOP-4406: Fixed React minified error in Suspense #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seungpark
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stories/Links:
DOP-4406
Current Behavior:
Landing
Cloud-docs
Staging Links:
Landing
Cloud-docs
Notes:
In the current prod site, you can see the react minified error #419 which is here.
This happens because of SSR hydration differences when using
React.Suspenseand Gatsby. There are a couple open issues with Gatsby for this (even one with our friend Grayson), but this PR introduces a very simple fix to allow the SSR to compile the static html with the fallback and allow stable hydration. Tricks on tricks. I would assume Gatsby will not be fixing this anytime soon.README updates