Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOP-2210: Match legacy sidebar breakpoint with snooty's #419

Merged
merged 2 commits into from
May 26, 2021
Merged

DOP-2210: Match legacy sidebar breakpoint with snooty's #419

merged 2 commits into from
May 26, 2021

Conversation

rayangler
Copy link
Collaborator

@rayangler rayangler commented May 25, 2021 •
edited
Loading

Stories/Links:

DOP-2210

Staging Links:

Realm Staging

Notes:

  • Legacy css for the sidebar had the component's breakpoint at 1120px while snooty's is 1024px. Changing the legacy css to match 1024px seems to solve this issue.
  • To test, resize viewport to be between 1024px and 1120px. The left nav should be visible by default. Compare with the current live site for drivers (link) and note that the sidebar no longer disappears.

@rayangler rayangler requested review from casthewiz and mango-db May 25, 2021 22:14
casthewiz
casthewiz approved these changes May 26, 2021
View reviewed changes
Copy link
Contributor

@casthewiz casthewiz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acceptance
Capture

Production
Capture2

🚀

mango-db
mango-db approved these changes May 26, 2021
View reviewed changes
Copy link
Contributor

@mango-db mango-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the standard browsers, & thanks!

mango-db
mango-db reviewed May 26, 2021
View reviewed changes
src/styles/mongodb-docs.css
@@ -12241,15 +12241,6 @@ div.admonition {
margin-right: 15px;
float: none;
}
#showNav {
Copy link
Contributor

@mango-db mango-db May 26, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit picking, I wonder if we could remove all or a substantial part of the original @media (max-width: 1120px) CSS block?

Copy link
Collaborator Author

@rayangler rayangler May 26, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Thanks for pointing that out. I didn't see those classes in our components and things seem to be okay on staging

@rayangler rayangler merged commit 0728117 into mongodb:master May 26, 2021
@rayangler rayangler deleted the DOP-2210 branch May 26, 2021 19:13
graysonhicks pushed a commit that referenced this pull request Jan 20, 2023
@rayangler
DOP-2210: Match legacy sidebar breakpoint with snooty's (#419)
6e10d47
@mmeigs mmeigs mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mango-db mango-db mango-db approved these changes

@casthewiz casthewiz casthewiz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rayangler @casthewiz @mango-db