-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(quotes): Belarusian lacinka quotes #4938
feat(quotes): Belarusian lacinka quotes #4938
Conversation
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/7558027893 |
Im not sure about duplicating the quotes just to use a different character set. Everytime someone would want to add a quote, they would need to add it in 2 files. |
Belarusian lacinka is not very popular and this language is more like tribute to traditions. Also I added same quotes because it is easier to me. If someone wants to add quotes he will add it to belarusian or belarusian lacinka. My addition opens up this language for users, so that they can then add what they want. |
Yeah but it just creates issues. Everytime someone adds a quote they have to add it in both places. And since you said that this is not very popular, i think it creates more issues than its worth. |
They're not required to add the same quotes in both languages |
Technically, but then whats the point of adding a quote file that people won't add quotes to |
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/7572557723 |
Changed "belarusian" to "belarusian_lacinka"
I don't said that people won't add quotes to lacinka. People who use belarusian lacinka will add quotes to lacinka and other people who use belarusian will add quotes to belarusian. |
Ok, thanks |
Belarusian lacinka quotes
Added the same quotes as in Belarusian, but in the Latin alphabet.
The language itself was added to the pull request, which was posted earlier.
Translations: