Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impr(language): add common javascript words, symbols and functions (@bdsqqq) #5869

Merged
merged 2 commits into from
Sep 12, 2024
Merged

impr(language): add common javascript words, symbols and functions (@bdsqqq) #5869

merged 2 commits into from
Sep 12, 2024

Conversation

bdsqqq
Copy link
Contributor

@bdsqqq bdsqqq commented Sep 10, 2024

Description

Adds commonly used symbols:

  • quotes,
  • ticks
  • double quotes
  • square brackets
  • curly brackets

Adds commonly used functions and patterns (eg: spread operations, arrows used in arrow functions)

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Sep 10, 2024
fehmer
fehmer reviewed Sep 11, 2024
View reviewed changes
frontend/static/languages/code_javascript.json Outdated
"{...attributes}",
"{...children}",
"{...rest}",
"className",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure about adding React or other framework code in the javascript language file. For e.g. backend javascript developers this is pretty useless. We could add code_react as a language.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes a lot of sense, idea of adding these came to mind since jQuery is in the list of words. Will remove the library related ones and open a new PR with react as a language. ty!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, there is a quote in the js language that is just a react example. Bringing it up in case you think this could be made into an issue and then removed

monkeytype/frontend/static/quotes/code_javascript.json

Line 30 in b315836

"source": "Basic React.js Example",

Copy link
Contributor Author

@bdsqqq bdsqqq Sep 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved frontend specific things to: #5873

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arguably the Apollo keywords readQuery, readFragment et al don't have a place either

Miodec
Miodec requested changes Sep 11, 2024
View reviewed changes
frontend/static/languages/code_javascript.json Outdated
"{...attributes}",
"{...children}",
"{...rest}",
"className",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree

@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Sep 11, 2024
@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Sep 11, 2024
@bdsqqq bdsqqq requested review from Miodec and fehmer September 11, 2024 11:57
@github-actions github-actions bot added the waiting for review Pull requests that require a review before continuing label Sep 11, 2024
Miodec
Miodec approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@Miodec Miodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@github-actions github-actions bot removed the waiting for review Pull requests that require a review before continuing label Sep 12, 2024
@Miodec Miodec merged commit dd93fdb into monkeytypegame:master Sep 12, 2024
16 checks passed
Miodec pushed a commit that referenced this pull request Sep 12, 2024
@bdsqqq @Miodec
impr(language): add common javascript words, symbols and functions (@…
033e4a6 
…bdsqqq) (#5869)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcousens dcousens dcousens left review comments

@Miodec Miodec Miodec approved these changes

@fehmer fehmer Awaiting requested review from fehmer

Assignees
No one assigned
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bdsqqq @dcousens @fehmer @Miodec @monkeytypegeorge