Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impr(language): add common javascript words, symbols and functions (@bdsqqq) #5869

Merged
merged 2 commits into from
Sep 12, 2024
Merged

impr(language): add common javascript words, symbols and functions (@bdsqqq) #5869

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8f1310
impr(language): add common javascript words, symbols and functions
bdsqqq Sep 10, 2024
9d76563
remove frontend specific words from js
bdsqqq Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
135 changes: 134 additions & 1 deletion frontend/static/languages/code_javascript.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,19 @@
"i++",
"${i}",
"${j}",
"[]",
"[].map()",
"[].filter()",
"[].reduce()",
"()",
"=>",
"{}",
"\"",
"'",
"`",
"\"\"",
"''",
"``",
"label",
"switch",
"case",
Expand Down Expand Up @@ -95,6 +108,126 @@
"try",
"catch",
"throw",
"finally"
"finally",
"{...props}",
"{...attributes}",
"{...children}",
"{...rest}",
"className",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure about adding React or other framework code in the javascript language file. For e.g. backend javascript developers this is pretty useless. We could add code_react as a language.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes a lot of sense, idea of adding these came to mind since jQuery is in the list of words. Will remove the library related ones and open a new PR with react as a language. ty!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, there is a quote in the js language that is just a react example. Bringing it up in case you think this could be made into an issue and then removed

monkeytype/frontend/static/quotes/code_javascript.json

Line 30 in b315836

"source": "Basic React.js Example",

Copy link
Contributor Author

@bdsqqq bdsqqq Sep 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved frontend specific things to: #5873

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arguably the Apollo keywords readQuery, readFragment et al don't have a place either

"React.createElement()",
"React.Fragment",
"React.useState()",
"React.useEffect()",
"React.useRef()",
"React.useCallback()",
"React.useMemo()",
"React.useReducer()",
"React.useContext()",
"React.useImperativeHandle()",
"React.forwardRef()",
"React.memo()",
"React.lazy()",
"React.Suspense",
"React.cloneElement()",
"React.isValidElement()",
"React.createContext()",
"React.createRef()",
"React.forwardRef()",
"React.Children",
"React.Component",
"React.Pure",
"useState()",
"useEffect()",
"useRef()",
"useCallback()",
"useMemo()",
"useReducer()",
"useContext()",
"useImperativeHandle()",
"forwardRef()",
"memo()",
"lazy()",
"Suspense",
"cloneElement()",
"isValidElement()",
"createContext()",
"createRef()",
"forwardRef()",
"Children",
"Component",
"Pure",
"createElement()",
"Fragment",
"<></>",
"useReducer()",
"useMemo()",
"useCallback()",
"useContext()",
"useRef()",
"useState()",
"useEffect()",
"memo()",
"lazy()",
"cloneElement()",
"isValidElement()",
"createContext()",
"createRef()",
"forwardRef()",
"Children",
"Component",
"Pure",
"createElement()",
"Fragment",
"useReducer()",
"useMemo()",
"useCallback()",
"useContext()",
"useQuery()",
"useMutation()",
"useSubscription()",
"useLazyQuery()",
"useApolloClient()",
"gql()",
"ApolloProvider",
"Query",
"Mutation",
"Subscription",
"LazyQuery",
"getApolloContext()",
"getApolloClient()",
"setContext()",
"setClient()",
"setDefaultOptions()",
"resetDefaultOptions()",
"clearStore()",
"addTypename()",
"removeTypename()",
"makeVar()",
"makeVarWithDefault()",
"makeArrayVar()",
"makeArrayVarWithDefault()",
"makeObjectVar()",
"makeObjectVarWithDefault()",
"watchQuery()",
"query()",
"mutate()",
"subscribeToMore()",
"onError()",
"onCompleted()",
"onNext()",
"updateQuery()",
"updateQueryWithVariables()",
"readQuery()",
"writeQuery()",
"readFragment()",
"writeFragment()",
"createUploadthing",
".input",
".middleware",
".onUploadComplete",
"createRouteHandler",
"callbackUrl",
"uploadthingId",
"uploadthingSecret"
]
}
Loading