Adds MaximumMultiplier as upper bound for dynamic fee multiplier
#1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notlesh
changed the title
MaximumMultiplier as upper bound for dynamic fee multiplier
notlesh
added
A0-pleasereview
nbaztec
approved these changes
Oct 10, 2022
girazoki
approved these changes
Oct 10, 2022
crystalin
changed the title
MaximumMultiplier as upper bound for dynamic fee multiplierMaximumMultiplier as upper bound for dynamic fee multiplier
notlesh
added
D1-audited👍
imstar15
pushed a commit
to AvaProtocol/moonbeam
that referenced
this pull request
May 16, 2023
…onbeam-foundation#1853) * Bump substrate * Bump polkadot * Oops, bump the right repo (fix substrate and polkadot repos) * Bump polkadot * Add MaximumMultiplier * fmt * Bump max fee to 100_000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Cherry-picks paritytech/substrate#12282 into our
moonbeam-polkadot-v0.9.29Substrate branch and adds aMaximumMultipliervalue to bound the multiplier in pallettransaction-payment.I picked an initial value of 1000 based on analysis from @nbaztec and the desire to have a value that will be "painful" but not impossibly expensive. It is certainly up for debate. IMO it should be high enough that it doesn't interfere with the normal multiplier algorithm and acts as a safety net.The value has been set to
100_000after discussion. This value is very high, but would prevent txns from being "impossibly expensive", thus acting as a safety net rather than something that would frequently interfere with the fee mechanism.