Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Maximum value for MultiplierUpdate #12282

Merged
merged 18 commits into from
Oct 6, 2022
Merged

Maximum value for MultiplierUpdate #12282

merged 18 commits into from
Oct 6, 2022

Conversation

Szegoo
Copy link
Contributor

@Szegoo Szegoo commented Sep 15, 2022 •
edited
Loading

Fixes #12240

polkadot companion: paritytech/polkadot#6021

Polkadot address: 126X27SbhrV19mBFawys3ovkyBS87SGfYwtwa8J2FjHrtbmA

@Szegoo Szegoo changed the title Maximum value for MultiplierUpdate Maximum value for MultiplierUpdate Sep 15, 2022
@Szegoo Szegoo mentioned this pull request Sep 16, 2022
Merged
@ggwpez ggwpez mentioned this pull request Sep 18, 2022
Closed
@kianenigma kianenigma self-requested a review September 20, 2022 13:07
@kianenigma kianenigma added the A0-please_review Pull request needs code review. label Sep 20, 2022
@kianenigma
Copy link
Contributor

@Szegoo would be good if you link to the issue properly https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

@Szegoo
Copy link
Contributor Author

Szegoo commented Sep 20, 2022

@Szegoo would be good if you link to the issue properly https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

Just noticed, sorry for this.

kianenigma
kianenigma approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@kianenigma kianenigma left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once my comments are resolved. As usual, please add your polkadot address as well.

Szegoo and others added 5 commits September 21, 2022 19:40
@Szegoo @kianenigma
Update frame/transaction-payment/src/lib.rs
c58bd09 
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
@Szegoo @kianenigma
Update frame/transaction-payment/src/lib.rs
717cb7e 
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
@Szegoo
fixes
b6b6e4a
@Szegoo
Merge branch 'paritytech:master' into transaction-payment-multiplier
8be1be3
@Szegoo
remove unused import
db5cdef
@Szegoo
Copy link
Contributor Author

Szegoo commented Sep 21, 2022

I have resolved the comments.

I have added my polkadot address, thanks :)

@kianenigma kianenigma added B7-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Sep 24, 2022
@notlesh
Copy link
Contributor

notlesh commented Sep 30, 2022

This PR is useful for Moonbeam, we'd love to see it get merged soon :)

@kianenigma
Copy link
Contributor

/tip small

@substrate-tip-bot
Copy link

@kianenigma A small tip was successfully submitted for Szegoo (126X27SbhrV19mBFawys3ovkyBS87SGfYwtwa8J2FjHrtbmA on polkadot).

https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frpc.polkadot.io#/treasury/tips tip

KiChjang
KiChjang approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@KiChjang KiChjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after addressing my comment.

ggwpez
ggwpez reviewed Oct 6, 2022
View reviewed changes
bin/node-template/runtime/src/lib.rs Outdated Show resolved Hide resolved
frame/transaction-payment/src/lib.rs Outdated Show resolved Hide resolved
frame/transaction-payment/src/lib.rs Show resolved Hide resolved
@kianenigma
Copy link
Contributor

bot merge

@paritytech-processbot paritytech-processbot bot merged commit a84def9 into paritytech:master Oct 6, 2022
notlesh added a commit to moonbeam-foundation/substrate that referenced this pull request Oct 6, 2022
@Szegoo @notlesh @kianenigma
Maximum value for MultiplierUpdate (paritytech#12282)
047da51 
* Maximum value for MultiplierUpdate

* Update frame/transaction-payment/src/lib.rs

Co-authored-by: Stephen Shelton <steve@brewcraft.org>

* Update lib.rs

* return constant

* fix in runtime

* Update frame/transaction-payment/src/lib.rs

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* Update frame/transaction-payment/src/lib.rs

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* fixes

* remove unused import

* Update lib.rs

* more readable

* fix

* fix nits

Co-authored-by: Stephen Shelton <steve@brewcraft.org>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
@notlesh notlesh mentioned this pull request Oct 6, 2022
Merged
@Szegoo Szegoo mentioned this pull request Oct 7, 2022
Merged
@Dengjianping Dengjianping mentioned this pull request Oct 11, 2022
Open
chevdor pushed a commit that referenced this pull request Oct 24, 2022
@Szegoo @notlesh
@kianenigma @chevdor
Maximum value for MultiplierUpdate (#12282)
0686961 
* Maximum value for MultiplierUpdate

* Update frame/transaction-payment/src/lib.rs

Co-authored-by: Stephen Shelton <steve@brewcraft.org>

* Update lib.rs

* return constant

* fix in runtime

* Update frame/transaction-payment/src/lib.rs

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* Update frame/transaction-payment/src/lib.rs

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* fixes

* remove unused import

* Update lib.rs

* more readable

* fix

* fix nits

Co-authored-by: Stephen Shelton <steve@brewcraft.org>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
@chevdor chevdor mentioned this pull request Oct 24, 2022
Closed
@github-actions github-actions bot mentioned this pull request Nov 10, 2022
Closed
@github-actions github-actions bot mentioned this pull request Nov 23, 2022
Closed
@AurevoirXavier AurevoirXavier mentioned this pull request Jan 10, 2023
Closed
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@Szegoo @notlesh
@kianenigma @ark0f
Maximum value for MultiplierUpdate (paritytech#12282)
e8bf598 
* Maximum value for MultiplierUpdate

* Update frame/transaction-payment/src/lib.rs

Co-authored-by: Stephen Shelton <steve@brewcraft.org>

* Update lib.rs

* return constant

* fix in runtime

* Update frame/transaction-payment/src/lib.rs

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* Update frame/transaction-payment/src/lib.rs

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* fixes

* remove unused import

* Update lib.rs

* more readable

* fix

* fix nits

Co-authored-by: Stephen Shelton <steve@brewcraft.org>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@notlesh notlesh notlesh left review comments

@KiChjang KiChjang KiChjang approved these changes

@kianenigma kianenigma kianenigma approved these changes

@ggwpez ggwpez ggwpez approved these changes

@bkchr bkchr Awaiting requested review from bkchr

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed.
Projects
Runtime / FRAME
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a maximum value for trait MultiplierUpdate
5 participants
@Szegoo @kianenigma @notlesh @KiChjang @ggwpez