This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
auto force authoring when runtime change #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4meta5
approved these changes
May 3, 2022
notlesh
approved these changes
May 3, 2022
librelois
added a commit
that referenced
this pull request
May 3, 2022
librelois
added a commit
to moonbeam-foundation/moonbeam
that referenced
this pull request
May 3, 2022
librelois
added a commit
to moonbeam-foundation/moonbeam
that referenced
this pull request
May 4, 2022
librelois
added a commit
to moonbeam-foundation/moonbeam
that referenced
this pull request
May 4, 2022
|
I had left that code out when nimbus got its own repo in hopes that we wouldn't need it again. However after we discovered paritytech/polkadot-sdk#64 I realized we would need it again, and opened paritytech/substrate#4. I think this PR solves paritytech/substrate#4, right? So I'll close that issue. |
RomiJones
pushed a commit
to SuperPlatformFunctionality/spf-part-evm
that referenced
this pull request
Aug 2, 2022
d5c5ceb0
pushed a commit
to SuperPlatformFunctionality/spf-part-evm
that referenced
this pull request
Aug 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The force-authoring code doesn't exist anymore, it seems to have been deleted by mistake when migrating the nimbus code into its own repository.
Indeed, I added the auto force-authoring at the time when the nimbus code was still in our cumulus fork: https://github.com/PureStake/cumulus/pull/3/files