auto force authoring when runtime change

nimbus-consensus/src/lib.rs

@@ -314,7 +314,28 @@ where
 		relay_parent: PHash,
 		validation_data: &PersistedValidationData,
 	) -> Option<ParachainCandidate<B>> {
-		let maybe_key = if self.skip_prediction {
+		// Determine if runtime change
+		let runtime_upgraded = if *parent.number() > sp_runtime::traits::Zero::zero() {
+			let at = BlockId::Hash(parent.hash());
+			let parent_at = BlockId::<B>::Hash(*parent.parent_hash());
+			use sp_api::Core as _;
+			let previous_runtime_version: sp_api::RuntimeVersion = self
+				.parachain_client
+				.runtime_api()
+				.version(&parent_at)
+				.expect("Runtime api access to not error.");
+			let runtime_version: sp_api::RuntimeVersion = self
+				.parachain_client
+				.runtime_api()
+				.version(&at)
+				.expect("Runtime api access to not error.");
+
+			previous_runtime_version != runtime_version
+		} else {
+			false
+		};
+
+		let maybe_key = if self.skip_prediction || runtime_upgraded {
 			first_available_key(&*self.keystore)
 		} else {
 			first_eligible_key::<B, ParaClient>(

nimbus-primitives/src/lib.rs

@@ -24,9 +24,9 @@
 use sp_application_crypto::KeyTypeId;
 use sp_runtime::traits::BlockNumberProvider;
 use sp_runtime::ConsensusEngineId;
-use sp_std::vec::Vec;
 #[cfg(feature = "runtime-benchmarks")]
 use sp_std::vec;
+use sp_std::vec::Vec;
 
 pub mod digests;
 mod inherents;
@@ -94,7 +94,7 @@ pub trait CanAuthor<AuthorId> {
 		vec![]
 	}
 	#[cfg(feature = "runtime-benchmarks")]
-	fn set_eligible_author(_slot: &u32) {} 
+	fn set_eligible_author(_slot: &u32) {}
 }
 /// Default implementation where anyone can author.
 ///

pallets/author-inherent/src/benchmarks.rs

@@ -17,7 +17,7 @@
 #![cfg(feature = "runtime-benchmarks")]
 
 use crate::{Call, Config, Pallet};
-use frame_benchmarking::{benchmarks};
+use frame_benchmarking::benchmarks;
 use frame_system::RawOrigin;
 use nimbus_primitives::CanAuthor;
 use nimbus_primitives::SlotBeacon;

pallets/author-inherent/src/lib.rs

@@ -42,9 +42,9 @@ pub mod weights;
 #[frame_support::pallet]
 pub mod pallet {
 	use super::*;
+	use crate::weights::WeightInfo;
 	use frame_support::pallet_prelude::*;
 	use frame_system::pallet_prelude::*;
-	use crate::weights::WeightInfo;
 
 	/// The Author Inherent pallet. The core of the nimbus consensus framework's runtime presence.
 	#[pallet::pallet]

pallets/author-slot-filter/src/lib.rs

@@ -138,11 +138,10 @@ pub mod pallet {
 			eligible.contains(author)
 		}
 		#[cfg(feature = "runtime-benchmarks")]
-		fn get_authors(slot: &u32) -> Vec<T::AccountId>  {
-		// Compute pseudo-random subset of potential authors
-		let (eligible, _) =
-			compute_pseudo_random_subset::<T>(T::PotentialAuthors::get(), slot);
-		eligible
+		fn get_authors(slot: &u32) -> Vec<T::AccountId> {
+			// Compute pseudo-random subset of potential authors
+			let (eligible, _) = compute_pseudo_random_subset::<T>(T::PotentialAuthors::get(), slot);
+			eligible
 		}
 	}