Add dummy precompile hook with rust and typescript tests #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParthDesai
added
B7-runtimenoteworthy
Coverage Report@@ Coverage Diff @@
## master add-dummy-precompile +/- ##
=======================================================
Coverage 64.77% 64.77% 0.00%
Files 66 66
Lines 9775 9775
=======================================================
Hits 6331 6331
Misses 3444 3444
|
girazoki
reviewed
Mar 27, 2024
test/suites/dev-frontier-template/test-eth-asset-address/test-eth-asset-address-creation.ts
Outdated
Show resolved
Hide resolved
girazoki
reviewed
Mar 27, 2024
girazoki
approved these changes
Mar 27, 2024
nanocryk
approved these changes
Mar 27, 2024
tmpolaczyk
reviewed
Mar 27, 2024
| @@ -439,3 +469,17 @@ pub type ForeignFungiblesTransactor = FungiblesAdapter< | |||
| /// Multiplier used for dedicated `TakeFirstAssetTrader` with `ForeignAssets` instance. | |||
| pub type AssetRateAsMultiplier = | |||
| AssetFeeAsExistentialDepositMultiplier<Runtime, WeightToFee, AssetRate, ForeignAssetsInstance>; | |||
|
|
|||
| #[test] | |||
| fn test_asset_id_to_account_conversion() { | |||
There was a problem hiding this comment.
I think we don't need this test
There was a problem hiding this comment.
Currently asset_id_to_account takes prefix as slice, instead of hard bound array. Then it does invoke copy_from_slice, which can panic, if the slice's size is not exact.
If the implementation changes tomorrow (i.e the expected size of the slice in the implementation), it need to be captured by the unit test (otherwise you would see panic during integration test or worse in dev environment). Which this test prevents.
There was a problem hiding this comment.
Let's discuss this offline. I am merging this as it is not blocker as of now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up PR for Moonsong-Labs/moonkit#32
This PR utilizes the hooks introduced in above PR and adds revert bytecode at the evm account derived from the asset id specified in the hook invocation. It also has rust unit test and typescript integration test.