This repository has been archived by the owner on Jan 21, 2022. It is now read-only.
Generalizations for notifications #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
alexjgriffith
force-pushed
the
generalizations-for-notifications
branch
from
40aa648
to
8c7f50a
Compare
hdurer
reviewed
Mar 6, 2018
lisp/mastodon-tl.el
Outdated
| "Generate byline for TOOT. | ||
|
|
||
| AUTHOR-BYLINE is function for adding the author portion of | ||
| the byline that takes one variable. By default it is `mastodon-tl--byline-author' |
There was a problem hiding this comment.
By defaultis now meaningless.
lisp/mastodon-tl.el
Outdated
| @@ -483,26 +489,39 @@ message is a link which unhides/hides the main body." | |||
| (mastodon-tl--render-text content) | |||
| (mastodon-tl--media toot)))) | |||
|
|
|||
| (defun mastodon-tl--toot (toot) | |||
| "Display TOOT content and byline." | |||
| (defun mastodon-tl--insert (toot body author-byline action-byline) | |||
There was a problem hiding this comment.
mastodon-tl--insert is too generic name.
If this going to be more generic than just inserting toots, we should come up with a good name for this generic "something" and then also rename the toot argument and fix the doc comment to not say toot.
lisp/mastodon-tl.el
Outdated
| "Display toot content and byline. | ||
|
|
||
| BODY will form the section of the toot above the byline. | ||
| AUTHOR-BYLINE and ACTION-BYLINE are optional functions that are passed to |
alexjgriffith
force-pushed
the
generalizations-for-notifications
branch
from
664f85a
to
3a1454b
Compare
- Made generalizations to toot and bylines to enable notifications. - Fixed tl tests to account for the new function arguments. - fixed whitespace
alexjgriffith
force-pushed
the
generalizations-for-notifications
branch
from
3a1454b
to
1af51c0
Compare
hdurer
approved these changes
Mar 8, 2018
jdenen
pushed a commit
that referenced
this pull request
Aug 10, 2018
* Added generalizations needed for adding notifications #37 - Made generalizations to toot and bylines to enable notifications. - Fixed tl tests to account for the new function arguments. - fixed whitespace
jdenen
pushed a commit
that referenced
this pull request
Aug 11, 2018
* Added generalizations needed for adding notifications #37 - Made generalizations to toot and bylines to enable notifications. - Fixed tl tests to account for the new function arguments. - fixed whitespace
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalizations of
mastodon-tl--tootandmastodon-tl--bylinethat allow them to be used to render notifications.Three new arguments are added to
mastodon-tl--tootmastodon-tl--byline-authormastodon-tl--byline-boostedI also removed the redundant removal of newlines in
mastodon-tl--timeline