This repository has been archived by the owner on Jan 21, 2022. It is now read-only.
Adds the notification timeline to mastodon.el closing #34. #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
alexjgriffith
force-pushed
the
notifications
branch
2 times, most recently
from
524e98c
to
b13f9c8
Compare
|
It looks like the tests for rendering the warnings wont pass since they depend on libxml2. |
alexjgriffith
force-pushed
the
notifications
branch
from
dab7f44
to
837d205
Compare
|
Now there seams to be an issue with the linting. I will try to fix this on Friday. |
hdurer
reviewed
Mar 8, 2018
lisp/mastodon-notifications.el
Outdated
| (let ((status (mastodon-tl--field 'status note))) | ||
| (mastodon-tl--insert-status | ||
| note | ||
| (replace-regexp-in-string |
There was a problem hiding this comment.
Might this be a good time to extract this regexp monster into a helper function somewhere?
lisp/mastodon-notifications.el
Outdated
| "[\t\n ]*\\'" "" | ||
| (if (mastodon-tl--has-spoiler status) | ||
| (mastodon-tl--spoiler status) | ||
| (mastodon-tl--content status))) |
| (mock (mastodon-http--get-json "https://instance.url/api/v1/notifications")) | ||
| (mastodon-notifications--get)))) | ||
|
|
||
| (defun mastodon-notifications--test-type (fun sample) |
|
BTW: If you wanted to write more tests but also got caught by the missing xml support: |
- Made generalizations to toot and bylines to enable notifications. - Fixed tl tests to account for the new function arguments. - fixed whitespace
- Can now handle notifications (follow reblog favourite and mention) - Tests for each of the rendering functions are included - Added keybinding N to mastodon.el for mastodon-notifications-get - added mastodon-notifications to ert-helper.el
…to mastodon-notifications
alexjgriffith
force-pushed
the
notifications
branch
from
3ee0903
to
11f674a
Compare
hdurer
approved these changes
Mar 10, 2018
Closed
jdenen
pushed a commit
that referenced
this pull request
Aug 10, 2018
- Can now handle notifications (follow reblog favourite and mention) - Tests for each of the rendering functions are included - Added keybinding N to mastodon.el for mastodon-notifications-get - added mastodon-notifications to ert-helper.el
jdenen
pushed a commit
that referenced
this pull request
Aug 11, 2018
- Can now handle notifications (follow reblog favourite and mention) - Tests for each of the rendering functions are included - Added keybinding N to mastodon.el for mastodon-notifications-get - added mastodon-notifications to ert-helper.el
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Note
This builds off of PR #174. Requesting a pull early to get feedback on commit f93d05c which adds the files
mastodon-notifications.elandmastodon-notifications-test.elto the package.