-
Notifications
You must be signed in to change notification settings - Fork 27
Adds the notification timeline to mastodon.el closing #34. #178
Conversation
524e98c
to
b13f9c8
Compare
It looks like the tests for rendering the warnings wont pass since they depend on libxml2. |
dab7f44
to
837d205
Compare
Now there seams to be an issue with the linting. I will try to fix this on Friday. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So cool! I love it.
lisp/mastodon-notifications.el
Outdated
(let ((status (mastodon-tl--field 'status note))) | ||
(mastodon-tl--insert-status | ||
note | ||
(replace-regexp-in-string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might this be a good time to extract this regexp monster into a helper function somewhere?
lisp/mastodon-notifications.el
Outdated
"[\t\n ]*\\'" "" | ||
(if (mastodon-tl--has-spoiler status) | ||
(mastodon-tl--spoiler status) | ||
(mastodon-tl--content status))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: indentation
(mock (mastodon-http--get-json "https://instance.url/api/v1/notifications")) | ||
(mastodon-notifications--get)))) | ||
|
||
(defun mastodon-notifications--test-type (fun sample) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused?
BTW: If you wanted to write more tests but also got caught by the missing xml support: |
- Made generalizations to toot and bylines to enable notifications. - Fixed tl tests to account for the new function arguments. - fixed whitespace
- Can now handle notifications (follow reblog favourite and mention) - Tests for each of the rendering functions are included - Added keybinding N to mastodon.el for mastodon-notifications-get - added mastodon-notifications to ert-helper.el
…to mastodon-notifications
3ee0903
to
11f674a
Compare
- Can now handle notifications (follow reblog favourite and mention) - Tests for each of the rendering functions are included - Added keybinding N to mastodon.el for mastodon-notifications-get - added mastodon-notifications to ert-helper.el
- Can now handle notifications (follow reblog favourite and mention) - Tests for each of the rendering functions are included - Added keybinding N to mastodon.el for mastodon-notifications-get - added mastodon-notifications to ert-helper.el
Changes
Note
This builds off of PR #174. Requesting a pull early to get feedback on commit f93d05c which adds the files
mastodon-notifications.el
andmastodon-notifications-test.el
to the package.