Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list-closed-tabs doesn't work on Fx46 and workaround #206

Open
scorecounter opened this issue Apr 19, 2016 · 1 comment
Open

list-closed-tabs doesn't work on Fx46 and workaround #206

scorecounter opened this issue Apr 19, 2016 · 1 comment

Comments

@scorecounter
Copy link

scorecounter commented Apr 19, 2016

As of Firefox 46, list-closed-tabs (最近閉じたタブを一覧表示して復元 - mooz deceives you) doesn't work because of syntax change of JavaScript.

Error message:

"missing ] after element list"

var closedTabs = [[tab.image || fav, tab.title] for each (tab in json.decode(ss.getClosedTabData(window)))];

So, I changed as below and works fine:

var closedTabs = json.decode(ss.getClosedTabData(window)).map(function (tab) {
    return [tab.image || fav, tab.title];
});

Thanks.

basyura added a commit to basyura/keysnail-config that referenced this issue May 21, 2016
list-closed-tabs doesn't work on Fx46 and workaround
mooz/keysnail#206
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants