Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(trace): clean outdated fields #121

Merged
merged 1 commit into from
Jul 24, 2024
Merged

refactor(trace): clean outdated fields #121

merged 1 commit into from
Jul 24, 2024

Conversation

FletcherMan
Copy link
Collaborator

@FletcherMan FletcherMan commented Jul 22, 2024 •
edited
Loading

1. Purpose or design rationale of this PR

refer to scroll-tech/go-ethereum#842

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@lispc @omerfirmak
refactor(trace): clean outdated fields (#842)
2c5b88d 
* clean trace: remove ExtraData, disable prestateTracer, collect bytecodes in top level

* more cleanup

* more cleanup

* refactor(trace): clean outdated fields

* fix bytecodes in trace

* chore: auto version bump [bot]

* chore: auto version bump [bot]

* use hexutil.Bytes

---------

Co-authored-by: Ömer Faruk Irmak <omerfirmak@gmail.com>
Co-authored-by: omerfirmak <omerfirmak@users.noreply.github.com>
Co-authored-by: lispc <lispc@users.noreply.github.com>
@FletcherMan FletcherMan requested a review from a team as a code owner July 22, 2024 03:35
@FletcherMan FletcherMan changed the title refactor(trace): clean outdated fields (#842) refactor(trace): clean outdated fields Jul 22, 2024
@FletcherMan FletcherMan merged commit c41d331 into main Jul 24, 2024
@FletcherMan FletcherMan deleted the refactor_trace_codebytes branch July 24, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanmorphl2 ryanmorphl2 ryanmorphl2 approved these changes

@GingerMM GingerMM Awaiting requested review from GingerMM GingerMM was automatically assigned from morph-l2/chain_dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FletcherMan @ryanmorphl2 @lispc