Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(trace): clean outdated fields #842

Merged
merged 17 commits into from
Jul 15, 2024
Merged

Conversation

lispc
Copy link

@lispc lispc commented Jun 21, 2024

1. Purpose or design rationale of this PR

  1. collect accessed bytecodes to top level inside BlockTrace struct.
  2. so we can remove ExtraData field
  3. and we can disable prestateTracer too

This PR can work well with deployed curie provers ( >= v0.11.4).

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

rollup/tracing/tracing.go Outdated Show resolved Hide resolved
core/types/l2trace.go Outdated Show resolved Hide resolved
@lispc lispc changed the title (testing) Refactor/trace/bytecodes (testing) refactor(trace): clean outdated fields Jun 21, 2024
@0xmountaintop 0xmountaintop self-assigned this Jun 21, 2024
@lispc lispc changed the title (testing) refactor(trace): clean outdated fields refactor(trace): clean outdated fields Jun 25, 2024
@lispc
Copy link
Author

lispc commented Jun 28, 2024

@omerfirmak can you merge instead of rebase-and-force-push next time? unfriendly for branch management..

@lispc lispc marked this pull request as ready for review July 10, 2024 03:37
omerfirmak
omerfirmak previously approved these changes Jul 10, 2024
omerfirmak
omerfirmak previously approved these changes Jul 12, 2024
@lispc
Copy link
Author

lispc commented Jul 15, 2024

@omerfirmak need another review

@0xmountaintop 0xmountaintop merged commit 0cecc19 into develop Jul 15, 2024
8 checks passed
@0xmountaintop 0xmountaintop deleted the refactor/trace/bytecodes branch July 15, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants