forked from ethereum/go-ethereum
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(trace): clean outdated fields #842
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lispc
commented
Jun 21, 2024
lispc
commented
Jun 21, 2024
lispc
changed the title
(testing) Refactor/trace/bytecodes
(testing) refactor(trace): clean outdated fields
Jun 21, 2024
omerfirmak
force-pushed
the
refactor/trace/bytecodes
branch
from
June 24, 2024 07:52
7aaa4aa
to
3c483da
Compare
lispc
changed the title
(testing) refactor(trace): clean outdated fields
refactor(trace): clean outdated fields
Jun 25, 2024
…ethereum into refactor/trace/bytecodes
@omerfirmak can you merge instead of rebase-and-force-push next time? unfriendly for branch management.. |
omerfirmak
previously approved these changes
Jul 10, 2024
omerfirmak
previously approved these changes
Jul 12, 2024
0xmountaintop
approved these changes
Jul 15, 2024
@omerfirmak need another review |
omerfirmak
approved these changes
Jul 15, 2024
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Purpose or design rationale of this PR
This PR can work well with deployed curie provers ( >= v0.11.4).
2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.go
been updated?4. Breaking change label
Does this PR have the
breaking-change
label?