-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/repay withdraw all gas cost #184
Closed
Rubilmax
wants to merge
29
commits into
feat/repay-withdraw-all
from
feat/repay-withdraw-all-gas-cost
Closed
Feat/repay withdraw all gas cost #184
Rubilmax
wants to merge
29
commits into
feat/repay-withdraw-all
from
feat/repay-withdraw-all-gas-cost
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto refactor/oracle-prices
…nto refactor/oracle-prices
…blue into refactor/oracle-prices
…ho-labs/blue into refactor/oracle-prices
perf(oracle): store price onto stack
Add fee cap
feat(extsload): expose generic storage getter
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gas cost of a
withdrawAll
in this case is:In other words, it saves almost 3k gas (~4%) to have a withdrawAll mechanism inside Blue
Note that the benefit of #183 is that
amount
needs to be calculated upfront by the integrator, which allows them to also have access to it afterwards. To have similar usecases, I usebalanceOf
to calculate the amount actuallywithdrawn
. Gas savings can be up to 4.5k if a return value is added towithdraw
, just like in #181 (gas diff showcased in #185).