Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add receiver #191

Merged
merged 9 commits into from
Jul 31, 2023
Merged

Add receiver #191

merged 9 commits into from
Jul 31, 2023

Conversation

MerlinEgalite
Copy link
Contributor

@MerlinEgalite MerlinEgalite commented Jul 27, 2023 •
edited by Rubilmax
Loading

Fixes #103
Closes #184

@MerlinEgalite MerlinEgalite marked this pull request as ready for review July 27, 2023 17:24
pakim249CAL
pakim249CAL previously approved these changes Jul 27, 2023
View reviewed changes
MathisGD
MathisGD reviewed Jul 27, 2023
View reviewed changes
src/Blue.sol Show resolved Hide resolved
test/forge/Blue.t.sol Outdated Show resolved Hide resolved
test/forge/Blue.t.sol Outdated Show resolved Hide resolved
@MathisGD MathisGD mentioned this pull request Jul 27, 2023
Merged
MathisGD
MathisGD reviewed Jul 28, 2023
View reviewed changes
test/forge/Blue.t.sol Outdated Show resolved Hide resolved
src/Blue.sol Show resolved Hide resolved
@MathisGD
Copy link
Contributor

Note that the same way as onBehalf, the receiver parameter adds some "danger to the interface": if you mess up with the address, you can loose your funds forever.

@MerlinEgalite
Copy link
Contributor Author

MerlinEgalite commented Jul 28, 2023 •
edited
Loading

Tests are failing, looking into that

EDIT: can't reproduce locally

@MathisGD
Copy link
Contributor

MathisGD commented Jul 28, 2023 •
edited
Loading

Tests are failing, looking into that

I think that it is because the receiver is Blue itself (fixed in #193)

EDIT: can't reproduce locally

you might need more fuzz runs

@pakim249CAL
Copy link
Contributor

Note that the same way as onBehalf, the receiver parameter adds some "danger to the interface": if you mess up with the address, you can loose your funds forever.

Has historically not been an issue with our currently deployed contracts though.

makcandrov
makcandrov previously approved these changes Jul 28, 2023
View reviewed changes
pakim249CAL
pakim249CAL previously approved these changes Jul 28, 2023
View reviewed changes
MathisGD
MathisGD previously approved these changes Jul 28, 2023
View reviewed changes
Jean-Grimal
Jean-Grimal previously approved these changes Jul 28, 2023
View reviewed changes
MathisGD
MathisGD previously approved these changes Jul 28, 2023
View reviewed changes
makcandrov
makcandrov previously approved these changes Jul 28, 2023
View reviewed changes
Rubilmax
Rubilmax reviewed Jul 31, 2023
View reviewed changes
test/forge/Blue.t.sol Outdated Show resolved Hide resolved
Jean-Grimal
Jean-Grimal previously approved these changes Jul 31, 2023
View reviewed changes
Rubilmax
Rubilmax previously approved these changes Jul 31, 2023
View reviewed changes
@MerlinEgalite MerlinEgalite mentioned this pull request Jul 31, 2023
Closed
pakim249CAL
pakim249CAL previously approved these changes Jul 31, 2023
View reviewed changes
@MathisGD MathisGD merged commit 1f2ba2a into main Jul 31, 2023
@MathisGD MathisGD deleted the feat/receiver branch July 31, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makcandrov makcandrov makcandrov approved these changes

@Jean-Grimal Jean-Grimal Jean-Grimal approved these changes

@MathisGD MathisGD MathisGD approved these changes

@pakim249CAL pakim249CAL pakim249CAL approved these changes

@Rubilmax Rubilmax Rubilmax approved these changes

@QGarchery QGarchery Awaiting requested review from QGarchery

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Specify receiver of funds for withdraw and borrow
6 participants
@MerlinEgalite @MathisGD @pakim249CAL @Rubilmax @Jean-Grimal @makcandrov