Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IRM whitelist #59

Merged
merged 25 commits into from
Jul 8, 2023
Merged

Add IRM whitelist #59

merged 25 commits into from
Jul 8, 2023

Conversation

MerlinEgalite
Copy link
Contributor

@MerlinEgalite MerlinEgalite commented Jul 5, 2023 •
edited
Loading

Fix #41

Todo

  • correct naming
  • tests
  • Improvement: use uint instead of bool?
  • Should we do a call to the irm to test that it works when whitelisting it?

Gas costs

Screenshot 2023-07-07 at 14 21 02

@MerlinEgalite MerlinEgalite linked an issue Jul 5, 2023 that may be closed by this pull request
IRMs #41
Closed
MathisGD
MathisGD reviewed Jul 5, 2023
View reviewed changes
src/Blue.sol Outdated Show resolved Hide resolved
src/interfaces/IIRM.sol Outdated Show resolved Hide resolved
src/Blue.sol Outdated Show resolved Hide resolved
src/Blue.sol Outdated Show resolved Hide resolved
@MerlinEgalite MerlinEgalite marked this pull request as ready for review July 5, 2023 18:32
@MerlinEgalite MerlinEgalite requested a review from MathisGD July 5, 2023 18:32
MathisGD
MathisGD reviewed Jul 6, 2023
View reviewed changes
src/interfaces/IIRM.sol Outdated Show resolved Hide resolved
src/Blue.sol Outdated Show resolved Hide resolved
src/Blue.sol Outdated Show resolved Hide resolved
src/mocks/IRMMock.sol Outdated Show resolved Hide resolved
test/forge/Blue.t.sol Outdated Show resolved Hide resolved
src/Blue.sol Outdated Show resolved Hide resolved
src/Blue.sol Show resolved Hide resolved
@MerlinEgalite MerlinEgalite requested a review from MathisGD July 6, 2023 09:17
@Rubilmax Rubilmax mentioned this pull request Jul 6, 2023
Merged
Rubilmax
Rubilmax reviewed Jul 6, 2023
View reviewed changes
test/forge/Blue.t.sol Outdated Show resolved Hide resolved
@Rubilmax Rubilmax mentioned this pull request Jul 6, 2023
Closed
pakim249CAL
pakim249CAL previously approved these changes Jul 7, 2023
View reviewed changes
makcandrov
makcandrov previously approved these changes Jul 7, 2023
View reviewed changes
Rubilmax
Rubilmax previously approved these changes Jul 7, 2023
View reviewed changes
@MerlinEgalite MerlinEgalite mentioned this pull request Jul 7, 2023
Closed
@MerlinEgalite MerlinEgalite dismissed stale reviews from Rubilmax, makcandrov, and pakim249CAL via 2c89aa9 July 7, 2023 17:20
@MerlinEgalite MerlinEgalite linked an issue Jul 7, 2023 that may be closed by this pull request
Capital letters for constants in tests #77
Closed
makcandrov
makcandrov previously approved these changes Jul 7, 2023
View reviewed changes
pakim249CAL
pakim249CAL previously approved these changes Jul 7, 2023
View reviewed changes
MathisGD
MathisGD previously approved these changes Jul 7, 2023
View reviewed changes
src/mocks/IrmMock.sol Outdated Show resolved Hide resolved
@MerlinEgalite MerlinEgalite dismissed stale reviews from MathisGD, pakim249CAL, and makcandrov via 6c1d842 July 8, 2023 07:58
@MerlinEgalite MerlinEgalite merged commit 0ceaeda into dev Jul 8, 2023
@MerlinEgalite MerlinEgalite deleted the feat/irm-whitelist branch July 8, 2023 09:07
@MathisGD MathisGD mentioned this pull request Jul 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makcandrov makcandrov makcandrov left review comments

@MathisGD MathisGD MathisGD left review comments

@pakim249CAL pakim249CAL pakim249CAL left review comments

@Rubilmax Rubilmax Rubilmax left review comments

@QGarchery QGarchery Awaiting requested review from QGarchery

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Capital letters for constants in tests IRMs
5 participants
@MerlinEgalite @Rubilmax @pakim249CAL @MathisGD @makcandrov