SceneData field specification optimizations #542
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally meant to be a part of #525, but at the very last second I realized nasty interactions with the compatibility single-function-object conversion tools, which have to get fixed first. Things to do:
SceneTools::combine()
aware of implicit null mappings and trivial fieldsSceneTools::convertToSingleFunctionObjects()
needs to be aware of these as wellSceneFieldFlag::ImplicitMapping
for fields passed tocombine()
, as those will turn implicit null fields into placeholdersLooks like I dug a really deep pit and then managed to fall at the very bottom. Yey. Or maybe there's some other solution / different way of implementing implicit or trivial fields without making them null? Some possibilities:
DataFlags
, etc.)?