Use ssl client certs for authentication. #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hildebrandttk
changed the title
|
Hey @hildebrandttk, Thanks for your contribution. Is this still WIP? |
mostafa
force-pushed
the
main
branch
4 times, most recently
from
e1b2bf9
to
6b5c295
Compare
mostafa
changed the title
|
@hildebrandttk Thanks again for your contribution! 🙏 I'll take it from here and merge it. |
Rename dialer constructors
Add docs for deleteTopic
Delete topics upon teardown
|
@hildebrandttk's changes fix #24 and the changes I've made fix #28. |
This was referenced May 4, 2022
|
👍 |
|
@hildebrandttk Were you able to connect successfully over TLS?If yes, how did you generate the pem files, please ? |
mostafa
added a commit
that referenced
this pull request
May 31, 2022
* Use ssl client certs for authentication. * Fix linting issue * Skip TLS config if the certificates and key files don't exist * Extract dialer creation into getAuthenticatedDialer function * ListTopics and CreateTopic now support authentication * Add DeleteTopic function * Fix issue with dialer being nil (return an unauthenticated dialer) * Rename dialer constructors * Document auth in topic handling functions * Add docs for deleteTopic * Create topic only on the first VU upon initialization * Delete topics upon teardown Co-authored-by: Stefan Hildebrandt <stefan.hildebrandt@externe.neuland-bfi.de> Co-authored-by: Mostafa Moradian <mostafamoradian0@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.