Added joint limits to rviz launch file. #3091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rviz now loads the moveit joint limits, enabling cartesian planning from rviz.
mikeferguson
approved these changes
Nov 14, 2024
sea-bass
reviewed
Nov 15, 2024
sea-bass
approved these changes
Nov 15, 2024
mikeferguson
approved these changes
Nov 15, 2024
mikeferguson
added
the
backport-humble
mergify bot
pushed a commit
that referenced
this pull request
Nov 27, 2024
* Added joint limits to rviz launch file. Rviz now loads the moveit joint limits, enabling cartesian planning from rviz. * Update moveit_configs_utils/moveit_configs_utils/launches.py --------- Co-authored-by: Sebastian Castro <4603398+sea-bass@users.noreply.github.com> (cherry picked from commit 0f4c935)
6 tasks
mikeferguson
pushed a commit
that referenced
this pull request
Nov 27, 2024
* Added joint limits to rviz launch file. Rviz now loads the moveit joint limits, enabling cartesian planning from rviz. * Update moveit_configs_utils/moveit_configs_utils/launches.py --------- Co-authored-by: Sebastian Castro <4603398+sea-bass@users.noreply.github.com> (cherry picked from commit 0f4c935) Co-authored-by: Matthew Elwin <10161574+m-elwin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rviz now loads the moveit joint limits, enabling cartesian planning from rviz.
Description
Addresses issue #2989 by having the rviz generator use the joint limits provided by the MoveItConfigsBuilder.
Currently, these joint limits are not added as parameters to rviz, which can break behavior such as cartesian path planning.
Checklist