Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added joint limits to rviz launch file. (backport #3091) #3136

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Nov 27, 2024

Rviz now loads the moveit joint limits, enabling cartesian planning from rviz.

Description

Addresses issue #2989 by having the rviz generator use the joint limits provided by the MoveItConfigsBuilder.
Currently, these joint limits are not added as parameters to rviz, which can break behavior such as cartesian path planning.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

This is an automatic backport of pull request #3091 done by [Mergify](https://mergify.com).

* Added joint limits to rviz launch file.

Rviz now loads the moveit joint limits, enabling cartesian planning from rviz.

* Update moveit_configs_utils/moveit_configs_utils/launches.py

---------

Co-authored-by: Sebastian Castro <4603398+sea-bass@users.noreply.github.com>
(cherry picked from commit 0f4c935)
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.27%. Comparing base (ed38b2d) to head (509b9fd).
Report is 1 commits behind head on humble.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #3136      +/-   ##
==========================================
- Coverage   42.27%   42.27%   -0.00%     
==========================================
  Files         668      668              
  Lines       57740    57742       +2     
  Branches     7322     7322              
==========================================
  Hits        24403    24403              
- Misses      33152    33153       +1     
- Partials      185      186       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikeferguson mikeferguson merged commit d13d835 into humble Nov 27, 2024
7 checks passed
@mikeferguson mikeferguson deleted the mergify/bp/humble/pr-3091 branch November 27, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants