-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contact PUT #112
Contact PUT #112
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @imbstack! I tried this in the swagger API. It is challenging due to issue #105, but my basic tests worked (add a minimal contact, update that contact).
The two big issues I see are the PUT path (/ctms
vs /ctms/{email_id}
), and the failing tests.
I envisioned this endpoint's strategy as "omitting a parameter means leave it alone", where instead it has the strategy of "make it look like what I sent you". That means that you always have to GET the existing object to update, and last writer wins. I think that is less useful for the way Basket uses it, but we can make it work.
Co-authored-by: John Whitlock <jwhitlock@mozilla.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @imbstack!
Proposed changes
Should approximately finish #55 (although there are a few discrepancies to clear up now that I look) Maybe worth doing in a followup though
Types of changes
What types of changes does your code introduce?
Checklist
Further comments
Use this space for additional comments, complications, learnings, alternatives,...