Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #733: fix replacing the list of waitlists in PUT requests #745

Merged
merged 5 commits into from
Jul 10, 2023

Conversation

leplatrem
Copy link
Contributor

Fix #733

I followed the idempotent PUT/GET roundtrip lead, and decided to delete existing waitlists that are not specified in a PUT request. This follows what was done for newsletters in #112

@leplatrem leplatrem requested a review from a team as a code owner July 6, 2023 15:06
@leplatrem leplatrem added the bug Something isn't working label Jul 6, 2023
tests/unit/routers/contacts/test_api.py Outdated Show resolved Hide resolved
tests/unit/conftest.py Show resolved Hide resolved
tests/unit/test_crud.py Outdated Show resolved Hide resolved
ctms/crud.py Outdated Show resolved Hide resolved
ctms/crud.py Outdated Show resolved Hide resolved
@leplatrem leplatrem requested a review from grahamalama July 7, 2023 15:46
@leplatrem leplatrem merged commit ff8f4a3 into main Jul 10, 2023
@leplatrem leplatrem deleted the 733-fix-waitlists-put branch July 10, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent handling of empty waitlists and newsletters lists when PUTing a contact
2 participants