Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Sync telemetry processing for the passwords engine #4556

Closed
grigoryk opened this issue Sep 27, 2019 · 0 comments
Closed

Sync telemetry processing for the passwords engine #4556

grigoryk opened this issue Sep 27, 2019 · 0 comments
Assignees
@grigoryk
Labels
E3 Estimation points: 3 <sync> Component: sync-logins <sync-logins> Component: Sync-Logins
Milestone
27.0.0 🎁

Comments

@grigoryk
Copy link
Contributor

grigoryk commented Sep 27, 2019 •
edited by data-sync-user
Loading

Follow-up to #4480.
In support-sync-telemetry we have metrics/pings for history and bookmarks, and now we need similar metrics for passwords as well.

Structure of all of these glean metrics and pings is really the same, so also take time to think through if we can generalize this somehow.

┆Issue is synchronized with this Jira Task
@grigoryk grigoryk added <sync-logins> Component: Sync-Logins <sync> Component: sync-logins labels Sep 27, 2019
@rfk rfk mentioned this issue Dec 4, 2019
Closed
@grigoryk grigoryk added the E3 Estimation points: 3 label Dec 11, 2019
@grigoryk grigoryk mentioned this issue Dec 12, 2019
Merged
6 tasks
bors bot pushed a commit that referenced this issue Dec 19, 2019
@MozLando @sblatz @gabrielluong
Merge #5285 #5294 #5360
19db6b3 
5285: Closes #5284: Adds progress bar to download notification r=pocmo a=sblatz



5294: Closes #4556: Passwords sync telemetry support r=rocketsroger,liuche a=grigoryk

This adds a new ping to `support-telemetry-sync` - passwords_sync, which is then used in `services-firefox-accounts` and in `service-sync-logins` to emit password sync telemetry whenever this engine is synchronized. New ping is a verbatim copy of the history_sync ping.

`samples-sync` app was also updated to demonstrate to how synchronize passwords, and how to protect encryption key at rest used for the password storage.



5360: Closes #5315 - Create a Top Sites storage component r=pocmo a=gabrielluong



Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
@bors bors bot closed this as completed in f046b61 Dec 19, 2019
@jonalmeida jonalmeida added this to the 27.0.0 🎁 milestone Dec 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@grigoryk grigoryk

Labels
E3 Estimation points: 3 <sync> Component: sync-logins <sync-logins> Component: Sync-Logins
Projects
None yet
Milestone
27.0.0 🎁
Development

No branches or pull requests
2 participants
@grigoryk @jonalmeida