This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Closes #5315 - Create a Top Sites storage component #5360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5360 +/- ##
========================================
Coverage 80.3% 80.3%
Complexity 4202 4202
========================================
Files 546 546
Lines 19174 19174
Branches 2766 2766
========================================
Hits 15398 15398
Misses 2616 2616
Partials 1160 1160Continue to review full report at Codecov.
|
gabrielluong
changed the title
gabrielluong
changed the title
|
bors r=pocmo |
Build failed
|
|
bors r=pocmo |
|
bors retry |
|
Already running a review |
|
bors retry Not sure why it failed when you tried. |
|
Already running a review |
|
bors r=pocmo |
|
Already running a review |
Build failed
|
|
bors retry |
1 similar comment
|
bors retry |
|
Already running a review |
bors bot
pushed a commit
that referenced
this pull request
Dec 19, 2019
5285: Closes #5284: Adds progress bar to download notification r=pocmo a=sblatz 5294: Closes #4556: Passwords sync telemetry support r=rocketsroger,liuche a=grigoryk This adds a new ping to `support-telemetry-sync` - passwords_sync, which is then used in `services-firefox-accounts` and in `service-sync-logins` to emit password sync telemetry whenever this engine is synchronized. New ping is a verbatim copy of the history_sync ping. `samples-sync` app was also updated to demonstrate to how synchronize passwords, and how to protect encryption key at rest used for the password storage. 5360: Closes #5315 - Create a Top Sites storage component r=pocmo a=gabrielluong Co-authored-by: Sawyer Blatz <sdblatz@gmail.com> Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com> Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
|
This PR was included in a batch that timed out, it will be automatically retried |
bors bot
pushed a commit
that referenced
this pull request
Dec 19, 2019
5294: Closes #4556: Passwords sync telemetry support r=rocketsroger,liuche a=grigoryk This adds a new ping to `support-telemetry-sync` - passwords_sync, which is then used in `services-firefox-accounts` and in `service-sync-logins` to emit password sync telemetry whenever this engine is synchronized. New ping is a verbatim copy of the history_sync ping. `samples-sync` app was also updated to demonstrate to how synchronize passwords, and how to protect encryption key at rest used for the password storage. 5360: Closes #5315 - Create a Top Sites storage component r=pocmo a=gabrielluong Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com> Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
Build succeeded
|
|
Thank you bors! |
|
bors +1 |
15 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5315 by adding an initial Top Sites storage component using
Roomsimilar toTabCollections. The current use case that this currently solves is that it provides a simple storage for top sites that are manually added/removed.Pull Request checklist
After merge