Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

AbstractFetchDownloadService leaks IntentReceiver #6881

Closed
csadilek opened this issue May 5, 2020 · 0 comments
Closed

AbstractFetchDownloadService leaks IntentReceiver #6881

csadilek opened this issue May 5, 2020 · 0 comments
Assignees
@Amejia481
Labels
🐞 bug Something isn't working <download> Component: feature-download E3 Estimation points: 3

Comments

@csadilek
Copy link
Contributor

csadilek commented May 5, 2020 •
edited by data-sync-user
Loading 

2020-05-05 17:47:40.646 11531-11531/org.mozilla.samples.browser E/ActivityThread: Service org.mozilla.samples.browser.downloads.DownloadService has leaked IntentReceiver mozilla.components.feature.downloads.AbstractFetchDownloadService$broadcastReceiver$2$1@5531a95 that was originally registered here. Are you missing a call to unregisterReceiver()?
    android.app.IntentReceiverLeaked: Service org.mozilla.samples.browser.downloads.DownloadService has leaked IntentReceiver mozilla.components.feature.downloads.AbstractFetchDownloadService$broadcastReceiver$2$1@5531a95 that was originally registered here. Are you missing a call to unregisterReceiver()?
        at android.app.LoadedApk$ReceiverDispatcher.<init>(LoadedApk.java:1588)
        at android.app.LoadedApk.getReceiverDispatcher(LoadedApk.java:1368)
        at android.app.ContextImpl.registerReceiverInternal(ContextImpl.java:1515)
        at android.app.ContextImpl.registerReceiver(ContextImpl.java:1488)
        at android.app.ContextImpl.registerReceiver(ContextImpl.java:1476)
        at android.content.ContextWrapper.registerReceiver(ContextWrapper.java:627)
        at mozilla.components.feature.downloads.AbstractFetchDownloadService.registerForUpdates(AbstractFetchDownloadService.kt:352)
        at mozilla.components.feature.downloads.AbstractFetchDownloadService.onStartCommand(AbstractFetchDownloadService.kt:216)
        at android.app.ActivityThread.handleServiceArgs(ActivityThread.java:4087)
        at android.app.ActivityThread.access$1800(ActivityThread.java:219)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1891)
        at android.os.Handler.dispatchMessage(Handler.java:107)
        at android.os.Looper.loop(Looper.java:214)
        at android.app.ActivityThread.main(ActivityThread.java:7356)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:492)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:930)

┆Issue is synchronized with this Jira Task
@csadilek csadilek added 🐞 bug Something isn't working <download> Component: feature-download labels May 5, 2020
@Amejia481 Amejia481 added the E3 Estimation points: 3 label May 7, 2020
@Amejia481 Amejia481 self-assigned this May 7, 2020
bors bot pushed a commit that referenced this issue May 7, 2020
@MozLando @Amejia481 @csadilek
Merge #6902 #6906
246fc69 
6902: Closes #6881: Register/unregister download notification actions receiver r=csadilek a=Amejia481



6906: Issue #2985: Support loading reader view ext. page in new session r=jonalmeida a=csadilek

Basically, a leftover from the refactoring. We used to turn on reader mode when the port connected and reader mode was active for this session. Now we have a separate page which could be loaded in a new session. When the reader extension page connect, we can simply "show" reader mode (and mark it as active for the session, but that part already worked.)

Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
@bors bors bot closed this as completed in cc550a1 May 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Amejia481 Amejia481

Labels
🐞 bug Something isn't working <download> Component: feature-download E3 Estimation points: 3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@csadilek @Amejia481