Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Implement onCreditCardSave in GeckoCreditCardsAddressesStorageDelegate #9838

Closed
gabrielluong opened this issue Mar 8, 2021 · 0 comments · Fixed by #11231
Closed

Implement onCreditCardSave in GeckoCreditCardsAddressesStorageDelegate #9838

gabrielluong opened this issue Mar 8, 2021 · 0 comments · Fixed by #11231
Assignees
@gabrielluong
Labels
<autofill> Credit Card, Addresses and Logins autofill functionality E3 Estimation points: 3
Milestone
102.0.0 🏵

Comments

@gabrielluong
Copy link
Member

gabrielluong commented Mar 8, 2021 •
edited by data-sync-user
Loading

Follow up to #9455. Depends on mozilla/application-services#3899.

┆Issue is synchronized with this Jira Task
@gabrielluong gabrielluong added E3 Estimation points: 3 <autofill> Credit Card, Addresses and Logins autofill functionality cc-autofill labels Mar 8, 2021
@gabrielluong gabrielluong changed the title Implement onAddressSave and onCreditCardSave in GeckoCreditCardsAddressesStorageDelegate Implement onCreditCardSave in GeckoCreditCardsAddressesStorageDelegate Mar 11, 2021
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Mar 11, 2021
@gabrielluong
Issue mozilla-mobile#9838: Introduce CreditCardValidationDelegate and…
5882595 
… implement onCreditCardSave in GeckoCreditCardsAddressesStorageDelegate
@gabrielluong gabrielluong mentioned this issue Mar 11, 2021
Closed
4 tasks
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Mar 11, 2021
@gabrielluong
Issue mozilla-mobile#9838: Introduce CreditCardValidationDelegate and…
7713049 
… implement onCreditCardSave in GeckoCreditCardsAddressesStorageDelegate
@gabrielluong gabrielluong self-assigned this Mar 11, 2021
@gabrielluong gabrielluong added this to the 74.0.0 milestone Mar 11, 2021
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Mar 12, 2021
@gabrielluong
Issue mozilla-mobile#9838: Introduce CreditCardValidationDelegate and…
d1f4baa 
… implement onCreditCardSave in GeckoCreditCardsAddressesStorageDelegate
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Mar 12, 2021
@gabrielluong
Issue mozilla-mobile#9838: Introduce CreditCardValidationDelegate and…
fc1898d 
… implement onCreditCardSave in GeckoCreditCardsAddressesStorageDelegate

- Introduces `CreditCardValidationDelegate` and a default implementation in `DefaultCreditCardValidationDelegate`
- Adds a `wipeLocal()` to `CreditCardsAddressesStorage` to clear out local state in between tests
- Implements `onCreditCardSave` in `GeckoCreditCardsAddressesStorageDelegate`
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Mar 13, 2021
@gabrielluong
Issue mozilla-mobile#9838: Introduce CreditCardValidationDelegate and…
78b9e18 
… implement onCreditCardSave in GeckoCreditCardsAddressesStorageDelegate

- Introduces `CreditCardValidationDelegate` and a default implementation in `DefaultCreditCardValidationDelegate`
- Adds a `wipeLocal()` to `CreditCardsAddressesStorage` to clear out local state in between tests
- Implements `onCreditCardSave` in `GeckoCreditCardsAddressesStorageDelegate`
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Mar 16, 2021
@gabrielluong
Issue mozilla-mobile#9838: Introduce CreditCardValidationDelegate and…
3932be0 
… implement onCreditCardSave in GeckoCreditCardsAddressesStorageDelegate

- Introduces `CreditCardValidationDelegate` and a default implementation in `DefaultCreditCardValidationDelegate`
- Adds a `wipeLocal()` to `CreditCardsAddressesStorage` to clear out local state in between tests
- Implements `onCreditCardSave` in `GeckoCreditCardsAddressesStorageDelegate`
@gabrielluong gabrielluong mentioned this issue Mar 16, 2021
Closed
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Apr 15, 2021
@gabrielluong
Issue mozilla-mobile#9838: Introduce CreditCardValidationDelegate and…
719b601 
… implement onCreditCardSave in GeckoCreditCardsAddressesStorageDelegate

- Introduces `CreditCardValidationDelegate` and a default implementation in `DefaultCreditCardValidationDelegate`
- Adds `wipeLocalAddresses()` and `wipeLocalCreditCards()` to `CreditCardsAddressesStorage` to clear out local state in between tests
- Implements `onCreditCardSave` in `GeckoCreditCardsAddressesStorageDelegate`
@gabrielluong gabrielluong modified the milestones: 74.0.0, 90.0.0 🌳 Apr 21, 2021
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 13, 2021
@gabrielluong
Issue mozilla-mobile#9838: Introduce CreditCardValidationDelegate and…
32e88a4 
… implement onCreditCardSave in GeckoCreditCardsAddressesStorageDelegate

- Introduces `CreditCardValidationDelegate` and a default implementation in `DefaultCreditCardValidationDelegate`
- Implements `onCreditCardSave` in `GeckoCreditCardsAddressesStorageDelegate`

Issue mozilla-mobile#9838: Introduce CreditCardValidationDelegate and implement onCreditCardSave in DefaultCreditCardsAddressesStorageDelegate

- Introduces `CreditCardValidationDelegate` and a default implementation in `DefaultCreditCardValidationDelegate`
- Implements `onCreditCardSave` in `GeckoCreditCardsAddressesStorageDelegate`
@gabrielluong gabrielluong removed this from the 90.0.0 🌳 milestone May 21, 2021
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Nov 30, 2021
@gabrielluong
Issue mozilla-mobile#9838: Introduce CreditCardValidationDelegate and…
fb33b2a 
… implement onCreditCardSave in GeckoCreditCardsAddressesStorageDelegate

- Introduces `CreditCardValidationDelegate` and a default implementation in `DefaultCreditCardValidationDelegate`
- Implements `onCreditCardSave` in `GeckoCreditCardsAddressesStorageDelegate`
- Refactors `CreditCard` from concept-engine to `CreditCardEntry` in concept-storage so that it can validated with the `CreditCardValidationDelegate`
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Dec 2, 2021
@gabrielluong
Issue mozilla-mobile#9838: Introduce CreditCardValidationDelegate and…
9aeb634 
… implement onCreditCardSave in GeckoCreditCardsAddressesStorageDelegate

- Introduces `CreditCardValidationDelegate` and a default implementation in `DefaultCreditCardValidationDelegate`
- Implements `onCreditCardSave` in `GeckoCreditCardsAddressesStorageDelegate`
- Refactors `CreditCard` from concept-engine to `CreditCardEntry` in concept-storage so that it can validated with the `CreditCardValidationDelegate`
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Dec 15, 2021
@gabrielluong
Issue mozilla-mobile#9838: Introduce CreditCardValidationDelegate and…
e3fdd35 
… implement onCreditCardSave in GeckoCreditCardsAddressesStorageDelegate

- Introduces `CreditCardValidationDelegate` and a default implementation in `DefaultCreditCardValidationDelegate`
- Implements `onCreditCardSave` in `GeckoCreditCardsAddressesStorageDelegate`
- Refactors `CreditCard` from concept-engine to `CreditCardEntry` in concept-storage so that it can validated with the `CreditCardValidationDelegate`
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Dec 16, 2021
@gabrielluong
Issue mozilla-mobile#9838: Introduce CreditCardValidationDelegate and…
362336e 
… implement onCreditCardSave in GeckoCreditCardsAddressesStorageDelegate

- Introduces `CreditCardValidationDelegate` and a default implementation in `DefaultCreditCardValidationDelegate`
- Implements `onCreditCardSave` in `GeckoCreditCardsAddressesStorageDelegate`
- Refactors `CreditCard` from concept-engine to `CreditCardEntry` in concept-storage so that it can validated with the `CreditCardValidationDelegate`
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Dec 20, 2021
@gabrielluong
Issue mozilla-mobile#9838: Introduce CreditCardValidationDelegate and…
7a5db55 
… implement onCreditCardSave in GeckoCreditCardsAddressesStorageDelegate

- Introduces `CreditCardValidationDelegate` and a default implementation in `DefaultCreditCardValidationDelegate`
- Implements `onCreditCardSave` in `GeckoCreditCardsAddressesStorageDelegate`
- Refactors `CreditCard` from concept-engine to `CreditCardEntry` in concept-storage so that it can validated with the `CreditCardValidationDelegate`
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Dec 28, 2021
@gabrielluong
Issue mozilla-mobile#9838: Introduce CreditCardValidationDelegate and…
f5d761f 
… implement onCreditCardSave in GeckoCreditCardsAddressesStorageDelegate

- Introduces `CreditCardValidationDelegate` and a default implementation in `DefaultCreditCardValidationDelegate`
- Implements `onCreditCardSave` in `GeckoCreditCardsAddressesStorageDelegate`
- Refactors `CreditCard` from concept-engine to `CreditCardEntry` in concept-storage so that it can validated with the `CreditCardValidationDelegate`
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Jan 3, 2022
@gabrielluong
Issue mozilla-mobile#9838: Introduce CreditCardValidationDelegate and…
d83badc 
… implement onCreditCardSave in GeckoCreditCardsAddressesStorageDelegate

- Introduces `CreditCardValidationDelegate` and a default implementation in `DefaultCreditCardValidationDelegate`
- Implements `onCreditCardSave` in `GeckoCreditCardsAddressesStorageDelegate`
- Refactors `CreditCard` from concept-engine to `CreditCardEntry` in concept-storage so that it can validated with the `CreditCardValidationDelegate`
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Jan 3, 2022
@gabrielluong
Issue mozilla-mobile#9838: Introduce CreditCardValidationDelegate and…
58fd9c3 
… implement onCreditCardSave in GeckoCreditCardsAddressesStorageDelegate

- Introduces `CreditCardValidationDelegate` and a default implementation in `DefaultCreditCardValidationDelegate`
- Implements `onCreditCardSave` in `GeckoCreditCardsAddressesStorageDelegate`
- Refactors `CreditCard` from concept-engine to `CreditCardEntry` in concept-storage so that it can validated with the `CreditCardValidationDelegate`
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Jan 3, 2022
@gabrielluong
Issue mozilla-mobile#9838: Introduce CreditCardValidationDelegate and…
334b131 
… implement onCreditCardSave in GeckoCreditCardsAddressesStorageDelegate

- Introduces `CreditCardValidationDelegate` and a default implementation in `DefaultCreditCardValidationDelegate`
- Implements `onCreditCardSave` in `GeckoCreditCardsAddressesStorageDelegate`
- Refactors `CreditCard` from concept-engine to `CreditCardEntry` in concept-storage so that it can validated with the `CreditCardValidationDelegate`
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Jan 3, 2022
@gabrielluong
Issue mozilla-mobile#9838: Introduce CreditCardValidationDelegate and…
ed66b98 
… implement onCreditCardSave in GeckoCreditCardsAddressesStorageDelegate

- Introduces `CreditCardValidationDelegate` and a default implementation in `DefaultCreditCardValidationDelegate`
- Implements `onCreditCardSave` in `GeckoCreditCardsAddressesStorageDelegate`
- Refactors `CreditCard` from concept-engine to `CreditCardEntry` in concept-storage so that it can validated with the `CreditCardValidationDelegate`
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Mar 14, 2022
@gabrielluong
Issue mozilla-mobile#9838: Introduce CreditCardValidationDelegate and…
0bfa520 
… implement onCreditCardSave in GeckoCreditCardsAddressesStorageDelegate

- Introduces `CreditCardValidationDelegate` and a default implementation in `DefaultCreditCardValidationDelegate`
- Implements `onCreditCardSave` in `GeckoCreditCardsAddressesStorageDelegate`
- Refactors `CreditCard` from concept-engine to `CreditCardEntry` in concept-storage so that it can validated with the `CreditCardValidationDelegate`
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Mar 19, 2022
@gabrielluong
Issue mozilla-mobile#9838: Introduce CreditCardValidationDelegate and…
177d70b 
… implement onCreditCardSave in GeckoCreditCardsAddressesStorageDelegate

- Introduces `CreditCardValidationDelegate` and a default implementation in `DefaultCreditCardValidationDelegate`
- Implements `onCreditCardSave` in `GeckoCreditCardsAddressesStorageDelegate`
- Refactors `CreditCard` from concept-engine to `CreditCardEntry` in concept-storage so that it can validated with the `CreditCardValidationDelegate`
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Mar 21, 2022
@gabrielluong
Issue mozilla-mobile#9838: Introduce CreditCardValidationDelegate and…
ee373fb 
… implement onCreditCardSave in GeckoCreditCardsAddressesStorageDelegate

- Introduces `CreditCardValidationDelegate` and a default implementation in `DefaultCreditCardValidationDelegate`
- Implements `onCreditCardSave` in `GeckoCreditCardsAddressesStorageDelegate`
- Refactors `CreditCard` from concept-engine to `CreditCardEntry` in concept-storage so that it can validated with the `CreditCardValidationDelegate`
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Mar 22, 2022
@gabrielluong
Issue mozilla-mobile#9838: Introduce CreditCardValidationDelegate and…
a29dc4f 
… implement onCreditCardSave in GeckoCreditCardsAddressesStorageDelegate

- Introduces `CreditCardValidationDelegate` and a default implementation in `DefaultCreditCardValidationDelegate`
- Implements `onCreditCardSave` in `GeckoCreditCardsAddressesStorageDelegate`
- Refactors `CreditCard` from concept-engine to `CreditCardEntry` in concept-storage so that it can validated with the `CreditCardValidationDelegate`
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Apr 5, 2022
@gabrielluong
Issue mozilla-mobile#9838: Introduce CreditCardValidationDelegate and…
e9854db 
… implement onCreditCardSave in GeckoCreditCardsAddressesStorageDelegate

- Introduces `CreditCardValidationDelegate` and a default implementation in `DefaultCreditCardValidationDelegate`
- Implements `onCreditCardSave` in `GeckoCreditCardsAddressesStorageDelegate`
- Refactors `CreditCard` from concept-engine to `CreditCardEntry` in concept-storage so that it can validated with the `CreditCardValidationDelegate`
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Apr 7, 2022
@gabrielluong
Issue mozilla-mobile#9838: Introduce CreditCardValidationDelegate and…
a47357b 
… implement onCreditCardSave in GeckoCreditCardsAddressesStorageDelegate

- Introduces `CreditCardValidationDelegate` and a default implementation in `DefaultCreditCardValidationDelegate`
- Implements `onCreditCardSave` in `GeckoCreditCardsAddressesStorageDelegate`
- Refactors `CreditCard` from concept-engine to `CreditCardEntry` in concept-storage so that it can validated with the `CreditCardValidationDelegate`
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Apr 7, 2022
@gabrielluong
Issue mozilla-mobile#9838: Introduce CreditCardValidationDelegate and…
ab8b5a5 
… implement onCreditCardSave in GeckoCreditCardsAddressesStorageDelegate

- Introduces `CreditCardValidationDelegate` and a default implementation in `DefaultCreditCardValidationDelegate`
- Implements `onCreditCardSave` in `GeckoCreditCardsAddressesStorageDelegate`
- Refactors `CreditCard` from concept-engine to `CreditCardEntry` in concept-storage so that it can validated with the `CreditCardValidationDelegate`
@gabrielluong gabrielluong added this to the 102.0.0 🏵 milestone May 3, 2022
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 3, 2022
@gabrielluong
Issue mozilla-mobile#9838: Introduce CreditCardValidationDelegate and…
fa1cc45 
… implement onCreditCardSave in GeckoCreditCardsAddressesStorageDelegate

- Introduces `CreditCardValidationDelegate` and a default implementation in `DefaultCreditCardValidationDelegate`
- Implements `onCreditCardSave` in `GeckoCreditCardsAddressesStorageDelegate`
- Refactors `CreditCard` from concept-engine to `CreditCardEntry` in concept-storage so that it can validated with the `CreditCardValidationDelegate`
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 3, 2022
@gabrielluong
Issue mozilla-mobile#9838: Introduce CreditCardValidationDelegate and…
42e0097 
… implement onCreditCardSave in GeckoCreditCardsAddressesStorageDelegate

- Introduces `CreditCardValidationDelegate` and a default implementation in `DefaultCreditCardValidationDelegate`
- Implements `onCreditCardSave` in `GeckoCreditCardsAddressesStorageDelegate`
- Refactors `CreditCard` from concept-engine to `CreditCardEntry` in concept-storage so that it can validated with the `CreditCardValidationDelegate`
@mergify mergify bot closed this as completed in #11231 May 4, 2022
mergify bot pushed a commit that referenced this issue May 4, 2022
@gabrielluong @mergify
Issue #9838: Introduce CreditCardValidationDelegate and implement onC…
c277fe7 
…reditCardSave in GeckoCreditCardsAddressesStorageDelegate

- Introduces `CreditCardValidationDelegate` and a default implementation in `DefaultCreditCardValidationDelegate`
- Implements `onCreditCardSave` in `GeckoCreditCardsAddressesStorageDelegate`
- Refactors `CreditCard` from concept-engine to `CreditCardEntry` in concept-storage so that it can validated with the `CreditCardValidationDelegate`
mcarare added a commit to mcarare/android-components that referenced this issue May 10, 2022
@mcarare
For mozilla-mobile#9838: Fix onCreditCardSave tests.
cea15a7 
Previous implementation made the tests pass regardless of the results in verify/assert.
mcarare added a commit to mcarare/android-components that referenced this issue May 10, 2022
@mcarare
For mozilla-mobile#9838: Fix onCreditCardSave tests.
7004226 
Previous implementation made the tests pass regardless of the results in verify/assert.
mcarare added a commit to mcarare/android-components that referenced this issue May 11, 2022
@mcarare
For mozilla-mobile#9838: Fix onCreditCardSave tests.
1a19781 
Previous implementation made the tests pass regardless of the results in verify/assert.
mcarare added a commit to mcarare/android-components that referenced this issue May 11, 2022
@mcarare
For mozilla-mobile#9838: Fix onCreditCardSave tests.
bf7966a 
Previous implementation made the tests pass regardless of the results in verify/assert.
mcarare added a commit to mcarare/android-components that referenced this issue May 11, 2022
@mcarare
For mozilla-mobile#9838: Fix onCreditCardSave tests.
394f715 
Previous implementation made the tests pass regardless of the results in verify/assert.
mergify bot pushed a commit that referenced this issue May 11, 2022
@mcarare @mergify
For #9838: Fix onCreditCardSave tests.
5e021e5 
Previous implementation made the tests pass regardless of the results in verify/assert.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gabrielluong gabrielluong

Labels
<autofill> Credit Card, Addresses and Logins autofill functionality E3 Estimation points: 3
Projects
None yet
Milestone
102.0.0 🏵
2 participants
@gabrielluong @jonalmeida