This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Run CI for #12649 #12696
Closed
Run CI for #12649 #12696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Image sharing currently only works when sharing to an app but not when using the Android Direct Share feature, where it fails with a SecurityException. "Direct Share" is what Android calls the app created shortcuts, i.e. individual chats from a messaging application. The code pretty much already does the right thing (i.e. setting the FLAG_GRANT_READ_URI_PERMISSION on the target intent as well as the Chooser action, as described in ACTION_CHOOSE Api docs[1]) but there's some platform internals that seem to go wrong here but we can work around it with this patch. https://issuetracker.google.com/issues/151386328 describes a similar Problem, especially mozilla-mobile#12 in there offers a similar workaround and an explanation: The underlying problem is that ACTION_SEND is using EXTRA_STREAM for the content URI. But the FLAG_GRANT_*_URI_PERMISSION mechanism only works with URIs in Intent.data and Intent.clipData. The framework contains some code that tries to work around this limitation. But it doesn't handle this particular case. Intent.createChooser() migrates the flags and data/clipData from the target Intent, but it does so before the framework had a chance to fix up the target Intent via Intent.migrateExtraStreamToClipData(). And indeed moving the clipData into the inner intent makes Direct Share work and preserves the image preview in the Intent. [1] file:///<SDK-DIR>/docs/reference/android/content/Intent.html#ACTION_CHOOSER If you need to grant URI permissions through a chooser, you must specify the permissions to be granted on the ACTION_CHOOSER Intent in addition to the EXTRA_INTENT inside. This means using setClipData(ClipData) to specify the URIs to be granted as well as FLAG_GRANT_READ_URI_PERMISSION and/or FLAG_GRANT_WRITE_URI_PERMISSION as appropriate.
|
|
|
Original PR landed. Closing this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run CI for #12649
Pull Request checklist
After merge
GitHub Automation
Fixes #12689
Fixes #12